Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github comments cannot be sent #6624

Closed
afxgroup opened this issue Oct 27, 2019 · 11 comments
Closed

Github comments cannot be sent #6624

afxgroup opened this issue Oct 27, 2019 · 11 comments
Labels
fixed-by-updating-brave needs-more-info The report requires more detail before we can decide what to do with this issue. webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@afxgroup
Copy link

I've noticed that i cannot send a comment on Github.
I mean i can write and send the comment but the comment is not published. And i have no error.
If i use chrome i have no problem

Brave on Windows 10 64bit

@afxgroup
Copy link
Author

Let me test..

@afxgroup
Copy link
Author

afxgroup commented Oct 27, 2019

Well it seems it doesn't work on some projects.,. like github.com/sba1/adtools/issues/77

@bsclifton bsclifton added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Oct 28, 2019
@bsclifton
Copy link
Member

@afxgroup do you have more information about the version you're on?

For example, can you visit brave://version and copy/paste some of the version information there?

@bsclifton bsclifton added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Oct 28, 2019
@afxgroup
Copy link
Author

Brave 0.69.135 Chromium: 77.0.3865.120 (Build ufficiale) (a 64 bit)
Revisione 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
Sistema operativo Windows 10 OS Version 1903 (Build 18362.418)
JavaScript V8 7.7.299.13
Flash (Disabilitata)
User-agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36
Riga di comando "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-chrome-google-url-tracking-client --disable-domain-reliability --disable-features=UnifiedConsent,AudioServiceOutOfProcess,AutofillServerCommunication,LookalikeUrlNavigationSuggestionsUI --enable-dom-distiller --enable-features=NewExtensionUpdaterService,WebUIDarkMode,SimplifyHttpsIndicator --extension-content-verification=enforce_strict --extensions-install-verification=enforce --no-pings --enable-features=SimplifyHttpsIndicator,WebUIDarkMode,NewExtensionUpdaterService --disable-features=LookalikeUrlNavigationSuggestionsUI,AutofillServerCommunication,AudioServiceOutOfProcess,UnifiedConsent --flag-switches-begin --flag-switches-end
Percorso eseguibile C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe
Percorso profilo C:\Users\andre\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default

@bsclifton
Copy link
Member

Great- thanks for sharing @afxgroup 😄

It may not make a difference, but are you able to upgrade to 0.70.121? (latest version) and try again?

@afxgroup
Copy link
Author

No.. just tried to comment on the same post and same problem.. The comment is removed from textbox, the "Comment" button is again disabled due the empty text but the comment is not sent

@afxgroup
Copy link
Author

The funny thing is that here is it possible to comment without any problem.. :D

@afxgroup
Copy link
Author

A funny thing (maybe is the problem). With chrome and adblocker i receive the message "You can't comment at this time". Disabling it fix the problem. Could be something into brave that cause the same problem?

@afxgroup
Copy link
Author

Yes i can confirm that disabling brave checks on that page fix the problem. So it seems the same problem is on chrome. But on chrome a message is display while on brave nothing is shown

@bsclifton
Copy link
Member

bsclifton commented Nov 5, 2019

@afxgroup maybe we can check your shield settings for GitHub.com?

Here's how mine look - important ones being the cross-site cookies and cross-site device recognition. If those are too strict, you may be seeing the problem
Screen Shot 2019-11-04 at 10 11 41 PM

@afxgroup
Copy link
Author

afxgroup commented Nov 7, 2019

Well, latest version seems to fix the problem. I'll close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-by-updating-brave needs-more-info The report requires more detail before we can decide what to do with this issue. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

No branches or pull requests

3 participants