Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ads regions are unavailable on Ubuntu after changing system locale #6560

Closed
btlechowski opened this issue Oct 21, 2019 · 5 comments
Closed

Comments

@btlechowski
Copy link

btlechowski commented Oct 21, 2019

Follow up to #5655

Important: the issue does not reproduce when Clean installed Ubuntu thus majority of users will not be affected. More info #6560 (comment)

On Ubuntu System language determines the ads region.
Limited number of locales makes it impossible to enable ads.
This is most prominent for Spanish locale, which will disable ads for all Spanish speaking countries.

Steps to Reproduce

  1. Setup system locale on Ubuntu (check below for instructions)
  2. Clean install Brave
  3. Run Brave
  4. Enable rewards
  5. Open brave://rewards

Setting up system locale:

  1. Open Language Support in Ubuntu
    image
  2. Install Spanish language
  3. Make Spanish default system locale
    image
  4. Click Apply System-Wide
  5. Click Regional Formats at the top
    image
  6. Change the Regional Formats to Espanol(Argentina)
  7. Click Apply System-Wide
  8. Restart system

Affected locales:
Argentina es_AR
Chile es_CL
Colombia es_CO
Ecuador es_EC
Mexico es_MX
Peru es_PE
Venezuela es_VE

Actual result:

ads are unavailable in this region
The locale command shows the following
image
Locale used to show ads is en_ES
Since en_ES is not supported ads region, the ads are unavailable
image

Note: It is possible to manually overwrite the system locale before launching Brave (clean install) and that fixes the issue.
LANG=es_AR.UTF-8 LANGUAGE=es_AR /usr/bin/brave-browser

Note: the most obvious way to fix it is to use Regional Formats which allows to set the right region.

Expected result:

ads are available
Locale used to show ads is es_AR

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

Miscellaneous Information:

cc @tmancey @rebron @brave/legacy_qa

@srirambv
Copy link
Contributor

Try running sudo dpkg-reconfigure locales and then select whichever locale you need. This should allow you to configure locales on Linux
image

@btlechowski
Copy link
Author

Followed the STR from the description.
Attached logs per discussion with @tmancey.
locale.txt
chrome_debug.log

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

@btlechowski
Copy link
Author

Thanks @srirambv, but it didn't work for me, even after system restart. The output from locale is the same as before your suggestion. Also ads are unavailable. Used locale es_AR. Has that actually worked for you?

@btlechowski
Copy link
Author

btlechowski commented Oct 21, 2019

Good news.

The issue does not reproduce when I clean installed Ubuntu.

Clean installed Ubuntu 19.10, Argentina.
Locale is set properly to es_AR
image
Ads are available:
image

Clean installed Ubuntu 18.04 LTS, Argentina.
Locale is set properly to es_AR
image
Ads are available:
image

This issue only reproduces when locale is changed to another locale which I think most user will not do.

cc @tmancey

@btlechowski btlechowski changed the title Some ads regions are unavailable on Ubuntu due to lack of system locales Some ads regions are unavailable on Ubuntu after changing system locale Oct 21, 2019
@rebron
Copy link
Collaborator

rebron commented Oct 25, 2019

@btlechowski I'm going to go ahead and close this one per your last comment.

@rebron rebron closed this as completed Oct 25, 2019
@btlechowski btlechowski added QA/No and removed QA/Yes labels Oct 26, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Nov 11, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants