Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit transactions are not listed #6535

Closed
srirambv opened this issue Oct 17, 2019 · 3 comments
Closed

Deposit transactions are not listed #6535

srirambv opened this issue Oct 17, 2019 · 3 comments

Comments

@srirambv
Copy link
Contributor

Description

Deposit transactions are not listed on wallet

Steps to Reproduce

  1. Create wallet
  2. Do a successful transaction and send ETH to a different wallet
  3. Wallet that received doesn't show deposit transaction only shows sent transactions

Actual result:

image

Expected result:

Should list both sent/deposit transactions similar to MM
image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS Linux

Component 0.1.17 and 1.0.11

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support labels Oct 17, 2019
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 25, 2019
@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 0.70.122

image

@ryanml ryanml self-assigned this Dec 13, 2019
@ryanml ryanml added this to the Ethereum Remote Client 0.1.31 milestone Dec 13, 2019
@ryanml
Copy link
Contributor

ryanml commented Dec 13, 2019

This is fixed in the latest upstream rebase and will be part of the next client release: https://github.com/brave/ethereum-remote-client/commits/master

@srirambv
Copy link
Contributor Author

srirambv commented Jan 8, 2020

Verification passed on

Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Linux
Component 0.1.34
  • Verified ETH deposits shows up as expected
    image
  • Verified deposit for ERC20 Tokens is not shown (Same behaviour on MM as well)

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.35
  • Verified ETH deposits shows up as expected
    image
  • Verified deposit for ERC20 Tokens is not shown (Same behaviour on MM as well)

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.2.42 Chromium: 79.0.3945.117 (Official Build) (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)
Component 0.1.36 via https://github.com/brave/ethereum-remote-client/releases/tag/0.1.36
  • Verified that ETH Deposit transactions are appearing under History when using main
  • Verified that ETH Deposit transactions are appearing under History when using ropsten
  • Verified that ERC20 Deposit transactions are not appearing under History (same as MM)

Screen Shot 2020-01-09 at 5 02 30 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants