Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDG URL is being updated on upgrade - follow up to 6187 #6469

Closed
LaurenWags opened this issue Oct 14, 2019 · 4 comments
Closed

DDG URL is being updated on upgrade - follow up to 6187 #6469

LaurenWags opened this issue Oct 14, 2019 · 4 comments

Comments

@LaurenWags
Copy link
Member

Description

Follow up from https://github.com/brave/internal/issues/647#issuecomment-541900942 and #6187

DDG search engine entry is being updated to new URL for existing users in certain cases.

Steps to Reproduce

pre-req: use DE, AU, NZ, IRL

  1. Install 0.69.x
  2. Set SE to Bing.
  3. Upgrade to 0.70.x
  4. Verify Bing was retained as SE default.
  5. View DDG URL from brave://settings/searchEngines

Actual result:

DDG entry shows new URL (DE):
Screen Shot 2019-10-14 at 16 45 34

DDG entry shows new URL (AU, NZ, IRL):
Screen Shot 2019-10-14 at 4 47 08 PM

Expected result:

DDG entry should retain previous URL even when it is not the default on upgrades:
Screen Shot 2019-10-14 at 4 47 51 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.70.115 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @bsclifton @brave/legacy_qa

@LaurenWags
Copy link
Member Author

Added to 0.70.x milestone and added release-blocking label per discussion with @rebron - please update if needed.

@bsclifton
Copy link
Member

@LaurenWags is this a dupe of #6424?

Fixing this might be difficult. Will talk with @rebron

@LaurenWags
Copy link
Member Author

Might be a dupe - in #6424 DDG was the default selection and in this issue, DDG is not the default SE selection, so per discussion with @rebron I understood that it should retain the old URL.

@bsclifton
Copy link
Member

bsclifton commented Oct 17, 2019

Closing as wontfix after discussion with @rebron. The lists shown are the "pre-populated" lists which change with locale (this is expected behavior).

The entries will remain there (untouched) if you either set as default engine or edit the keyword (ex: user interacts with it). I believe these types of changes are saved in Default/Secure Preferences and Default/Web Data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants