Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled shields for a website are ignored by cookie service #6464

Closed
iefremov opened this issue Oct 14, 2019 · 1 comment · Fixed by brave/brave-core#3690
Closed

Disabled shields for a website are ignored by cookie service #6464

iefremov opened this issue Oct 14, 2019 · 1 comment · Fixed by brave/brave-core#3690
Assignees
@iefremov
Labels
priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.70.x - Release

Comments

@iefremov
Copy link
Contributor

iefremov commented Oct 14, 2019 •
edited by bsclifton
Loading

Description

Disabling shields does not allows 3p cookies (if cookie preference was not changed for a given website).

Steps to Reproduce

  1. Open https://www.whatismybrowser.com/detect/are-third-party-cookies-enabled
  2. Shields down
  3. 3p cookies are still blocked

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
@iefremov iefremov self-assigned this Oct 14, 2019
iefremov pushed a commit to brave/brave-core that referenced this issue Oct 14, 2019
Issue 6464: Do not forget about shields while calculating cookie rules.
4060967 
Fix brave/brave-browser#6464
@iefremov iefremov mentioned this issue Oct 14, 2019
Merged
32 tasks
@iefremov iefremov added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Oct 14, 2019
bridiver pushed a commit to brave/brave-core that referenced this issue Oct 15, 2019
@bridiver
Issue 6464: Do not forget about shields while calculating cookie rules.
671efa7 
Fix brave/brave-browser#6464
This was referenced Oct 15, 2019
Merged
Merged
@bsclifton bsclifton added this to the 0.70.x - Release milestone Oct 16, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Oct 17, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)
  • Reproduced the issue using 0.70.117.
  • Verified STR from description with 0.70.118.

Screen Shot 2019-10-17 at 12 09 56 PM

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS
  • Verified STR from description

image

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)

  • Reproduced the issue using 0.70.117.
    image

  • Verified STR from description with 0.70.118
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iefremov iefremov

Labels
priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Include shield content settings into cookie rules brave/brave-core
5 participants
@iefremov @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya