Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Translation for Secrete Backup Phrase screen content #6298

Closed
GeetaSarvadnya opened this issue Oct 3, 2019 · 4 comments
Closed

Missing Translation for Secrete Backup Phrase screen content #6298

GeetaSarvadnya opened this issue Oct 3, 2019 · 4 comments

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #5686
Missing Translation for Secrete Backup Phrase screen content

Steps to Reproduce

  1. Set device locale to Spanish
  2. Create a new profile and launch Crypto wallet
  3. Navigate to Secrete Backup Phrase
  4. Secrete Backup Phrase content isn't translated to Spanish

Actual result:

Missing Translation for Secrete Backup Phrase screen content
image

Expected result:

Secrete Backup Phrase content should be translated to Spanish

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @bbondy @kjozwiak

@GeetaSarvadnya GeetaSarvadnya added l10n QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support labels Oct 3, 2019
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Oct 3, 2019

Missing translation for Backup now button - It's not translated to Spanish

image

@kjozwiak
Copy link
Member

kjozwiak commented Oct 3, 2019

@bbondy possible that MM missing some translations on Spanish?

@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Dec 20, 2019
@bbondy bbondy added this to the Ethereum Remote Client 1.0.25 milestone Dec 15, 2020
@bbondy
Copy link
Member

bbondy commented Dec 15, 2020

This should be fixed as part of #13191

@srirambv
Copy link
Contributor

srirambv commented Jan 7, 2021

Verification passed on

Brave 1.19.74 Chromium: 87.0.4280.101 (Official Build) beta (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Linux
Component 1.0.19 Dev
  • Verified text is translated on Secret Backup Phrase screen
  • image
  • Verified text is translated on Backup Now button
    image

Verification passed on

Brave 1.18.77 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Windows 10 OS Version 2009 (Build 19042.685)
Component 1.0.19 Dev
  • Verified text is translated on Secret Backup Phrase screen
    image

  • Verified text is translated on Backup Now button
    image


Verification passed on

Brave 1.20.58 Chromium: 88.0.4315.7 (Official Build) nightly (x86_64)
Revision 9b020863b2987261f6dcd018c6b388041c035f98-refs/branch-heads/4315@{#15}
OS macOS Version 10.15.7 (Build 19H114)
Component 1.0.19 Dev
  • Verified text is translated on Secret Backup Phrase screen
    image

  • Verified text is translated on Backup Now button
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants