Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipping Thank You/Confirmation should be inline #6151

Closed
ryanml opened this issue Sep 24, 2019 · 2 comments · Fixed by brave/brave-core#3789
Closed

Tipping Thank You/Confirmation should be inline #6151

ryanml opened this issue Sep 24, 2019 · 2 comments · Fixed by brave/brave-core#3789

Comments

@ryanml
Copy link
Contributor

ryanml commented Sep 24, 2019

Screen Shot 2019-09-24 at 2 54 39 PM

Test Plan:

  1. Enable Rewards
  2. Opening the tipping banner for a publisher.
  3. Send a Tip
  4. Confirm that the old overlay does not show and instead the new inline confirmation shows up
  5. Confirm that share links work as expected
@ryanml
Copy link
Contributor Author

ryanml commented Sep 24, 2019

@jenn-rhim do we have a design for the new Monthly variant's confirmation? Not sure if we wanted to show one with the orange scheme. cc: @NejcZdovc

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 21, 2019

Verification passed on

Brave 1.2.7 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.2.6 Chromium: 78.0.3904.97 (Official Build) dev (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.2.40 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.15.2 (Build 19C57)

Screen Shot 2020-01-02 at 9 56 40 PM

Screen Shot 2020-01-02 at 9 59 35 PM

Screen Shot 2020-01-02 at 10 00 06 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment