Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipping Banner should be more accessible #6147

Closed
ryanml opened this issue Sep 24, 2019 · 3 comments · Fixed by brave/brave-core#3531 or brave/brave-core#4183
Closed

Tipping Banner should be more accessible #6147

ryanml opened this issue Sep 24, 2019 · 3 comments · Fixed by brave/brave-core#3531 or brave/brave-core#4183

Comments

@ryanml
Copy link
Contributor

ryanml commented Sep 24, 2019

Screen Shot 2019-09-24 at 11 34 06 AM

The following updates should be made:

  1. Banner must receive focus upon opening.
  2. ESC key must close banner.
  3. Choice A button for BAT tip amount must be pre-selected upon banner open.
  4. "SEND TIP" button changes shape as shown.
  5. "SEND TIP" button is pre-focused so that RETURN key executes send action and closes banner window.
  6. ALL 4 buttons present in this panel are set to receive focus for accessibility when tabbing through action elements.
  7. Update default text to reflect copy shown in photo.
@NejcZdovc
Copy link
Contributor

@davidtemkin I would go with mid option and not with lower option by default

ryanml added a commit to brave/brave-core that referenced this issue Oct 1, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 8, 2019
ryanml added a commit to brave/brave-core that referenced this issue Oct 9, 2019
@LaurenWags
Copy link
Member

Questions have been added to the spec for @mandar-brave @alexwykoff to address in regards to item 3 and 7 from description.

@LaurenWags
Copy link
Member

LaurenWags commented Nov 18, 2019

Verified passed with

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-11-18 at 3 44 05 PM

* Confirmed custom banners still display as expected.

Screen Shot 2019-11-18 at 3 11 14 PM

Verification passed on

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment