Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Cayman Islands and some other protectorates/territories for Brave Ads #6006

Closed
jsecretan opened this issue Sep 13, 2019 · 2 comments · Fixed by brave/brave-core#3512
Closed

Enable Cayman Islands and some other protectorates/territories for Brave Ads #6006

jsecretan opened this issue Sep 13, 2019 · 2 comments · Fixed by brave/brave-core#3512
Assignees
@tmancey
Labels
feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Milestone
1.1.x - Release

Comments

@jsecretan
Copy link

Description

Need to enable some additional territories/protectorates for Brave Ads, including the following country codes:

KY
@jsecretan jsecretan added priority/P3 The next thing for us to work on. It'll ride the trains. feature/ads labels Sep 13, 2019
@tmancey tmancey mentioned this issue Sep 23, 2019
Merged
32 tasks
@tmancey tmancey added the QA/Yes label Sep 23, 2019
@tmancey tmancey added this to the 0.72.x - Nightly milestone Sep 23, 2019
tmancey added a commit to brave/brave-core that referenced this issue Sep 25, 2019
@tmancey
Enable Cayman Islands and some other protectorates/territories for Br…
a5dc3b3 
…ave Ads

Fixes brave/brave-browser#6006
@LaurenWags
Copy link
Member

Adding QA/Blocked label pending discussion about testing cc @kjozwiak

This was referenced Dec 2, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

Per discussion with @jsecretan and @kjozwiak I am marking this as QA/No since QA could not test this one. However, as a sanity check, confirmed with Brave staff in KY that ad notifications are being generated for them.

@LaurenWags LaurenWags mentioned this issue Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging a pull request may close this issue.

Enable Cayman Islands and some other protectorates/territories for Brave Ads brave/brave-core
4 participants
@jsecretan @tmancey @kjozwiak @LaurenWags