Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips should be split in to two panels on brave://rewards #5957

Closed
ryanml opened this issue Sep 10, 2019 · 1 comment · Fixed by brave/brave-core#3394
Closed

Tips should be split in to two panels on brave://rewards #5957

ryanml opened this issue Sep 10, 2019 · 1 comment · Fixed by brave/brave-core#3394

Comments

@ryanml
Copy link
Contributor

ryanml commented Sep 10, 2019

There should be separate tables for monthly recurring and one time tips

Screen Shot 2019-09-09 at 7 10 53 PM

Screen Shot 2019-09-09 at 7 10 46 PM

@ryanml ryanml added this to the 0.72.x - Nightly milestone Sep 10, 2019
@ryanml ryanml self-assigned this Sep 10, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 12, 2019
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels Sep 16, 2019
@NejcZdovc NejcZdovc removed this from the 0.71.x - Dev milestone Sep 18, 2019
@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Sep 20, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 20, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 26, 2019
@btlechowski
Copy link

btlechowski commented Nov 14, 2019

Verification passed on

Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3394

image
image
image
image

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

(Verified in staging env in both clean and upgraded profile)

  • Verified test plan from Separates monthly and one time tips in to two panels brave-core#3394
  • Send 5 BAT recurring tip and 3 BAT one-time tips to a publisher in 1.0.0 and upgrade it to 5.1.1 - Verified that 5 BAT recurring tip displayed in Monthly tip panel in brave://rewards page and one-time tips remained in Tips panel as expected after the upgrade
    image
    image
    image

Verified passed with

Brave 1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified test plan from Separates monthly and one time tips in to two panels brave-core#3394 on a clean profile
    • Also verified able to remove recurring tips from Monthly Contributions panel and the Total contributions this month value updated appropriately.
  • Verified the following upgrade scenario:
    • Set up one time and recurring tips on a profile with 1.0.0.
    • Upgraded to 1.1.2.
    • Verified Tips panel only showed one time tips on upgrade.
    • Verified recurring tips were shown in the Monthly Contributions panel.
    • Verified able to remove recurring tips from Monthly Contributions panel.
    • Verified new recurring and one time tips were shown in the correct panels.

Screen Shot 2019-11-15 at 3 06 44 PM

Screen Shot 2019-11-15 at 3 06 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants