Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Chrome" browser references in brave://about page #5775

Closed
lukemulks opened this issue Aug 23, 2019 · 10 comments · Fixed by brave/brave-core#8970
Closed

"Chrome" browser references in brave://about page #5775

lukemulks opened this issue Aug 23, 2019 · 10 comments · Fixed by brave/brave-core#8970
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages branding OS/Android Fixes related to Android browser functionality OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/exclude

Comments

@lukemulks
Copy link

Description

"Chrome" is displayed for all of the URLs and browser references within the brave://about page

Steps to Reproduce

  1. navigate to brave://about
  2. observe Chrome used in the page, title, tab and urls

Actual result:

Expected result:

All instances of "Chrome" should be replaced with "Brave"

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 0.70.72 
Chromium: 76.0.3809.100 (Official Build) dev (64-bit)
-- | --
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Windows 10 
OS Version 1803 (Build 17134.950)

Version/Channel Information:

  • Can you reproduce this issue with the current release? unknown
  • Can you reproduce this issue with the beta channel? unknown
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@lukemulks lukemulks added the about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages label Aug 23, 2019
@lukemulks
Copy link
Author

@rebron assigned you on this one - suspect you'd likely know the best path forward in queue.

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Aug 23, 2019
@srirambv
Copy link
Contributor

+1 from @bershanskiy via #6438

@bershanskiy
Copy link

@srirambv Thank you for closing my duplicate.

@bershanskiy
Copy link

@rebron Have you started working on this yet? If not, may I make a PR and tag you on it?

@rebron rebron removed their assignment Oct 11, 2019
@rebron
Copy link
Collaborator

rebron commented Oct 11, 2019

@bershanskiy go ahead and grab, that would be great.

@aussiechief
Copy link

While just cosmetic, this is also the case in brave://settings, brave://rewards, brave://history, brave://bookmarks, brave://downloads, etc. All cross-referencing links are still using the chrome:// protocol.

@srirambv
Copy link
Contributor

+1 from @rahulsnkr via #15357

@srirambv
Copy link
Contributor

+1 from @bcat1023 via #15876

@stephendonner
Copy link

Verified PASSED using

Brave 1.27.62 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. loaded chrome://about
  3. confirmed I was redirected to brave://about/
  4. confirmed page title is Brave URLs
  5. confirmed page heading is List of Brave URLs
  6. confirmed although links go to chrome:// they are internally redirected to their respective brave:// counterpart
  7. confirmed that manually entering chrome://crash and brave://crash end at up brave://crash - did this for several other internal URL schemes
example example
Screen Shot 2021-06-14 at 1 40 51 PM Screen Shot 2021-06-14 at 1 47 38 PM

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 11.27.75 x64 Beta build


Verification passed on Samsung Tab A with Android 10 running 11.27.75 x64 Beta build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages branding OS/Android Fixes related to Android browser functionality OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
9 participants