Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipping a user's likes on Twitter results in incorrect username in tweet message #5685

Closed
emerick opened this issue Aug 15, 2019 · 1 comment · Fixed by brave/brave-core#6671

Comments

@emerick
Copy link
Contributor

emerick commented Aug 15, 2019

Steps to Reproduce

  1. Visit twitter.com/brave/likes
  2. Click tip button on any Tweet
  3. Click the Tweet button after tipping

Expected result

I just tipped @correctuser using the Brave Browser. Check it out at https://brave.com/tips. #TipWithBrave

Actual result

I just tipped @likes using the Brave Browser. Check it out at https://brave.com/tips. #TipWithBrave

Reported by @jonathansampson. Also occurs with twitter.com/brave/with_replies and twitter.com/brave/media, so we should handle all of these properly.

@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 20, 2019
@emerick emerick self-assigned this Oct 2, 2020
@NejcZdovc NejcZdovc added this to the 1.17.x - Nightly milestone Oct 6, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Oct 15, 2020

Verified passed with

Brave | 1.17.34 Chromium: 86.0.4240.99 (Official Build) nightly (x86_64)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified STR from description for:

Note - need to be logged in to Twitter to access the above pages.

Confirmed after clicking on an in-line tip button for a tweet on each page and tipping that tweet, when I clicked on the Twitter icon from the tipping banner, the canned tweet was pre-populated correctly.

Screenshots Screen Shot 2020-10-15 at 2 39 49 PM Screen Shot 2020-10-15 at 2 42 34 PM Screen Shot 2020-10-15 at 2 41 33 PM

Verification passed on


Brave | 1.17.42 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
-- | --
Revision | 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS | Windows 10 OS Version 1903 (Build 18362.1082)

Confirmed after clicking on an in-line tip button for a tweet on each page and tipping that tweet, when I clicked on the Twitter icon from the tipping banner, the canned tweet was pre-populated correctly.

image
image
image
image
image


Verification passed on

Brave 1.17.43 Chromium: 86.0.4240.99 (Official Build) nightly (64-bit)
Revision 002668237e13d38aabd6d11c2d216dd22b736ff2-refs/branch-heads/4240@{#1229}
OS Ubuntu 18.04 LTS

Verified STR from description for:

Note - need to be logged in to Twitter to access the above pages.

Confirmed after clicking on an in-line tip button for a tweet on each page and tipping that tweet, when I clicked on the Twitter icon from the tipping banner, the canned tweet was pre-populated correctly.

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants