Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced page elements on theguardian.com #5675

Closed
btlechowski opened this issue Aug 15, 2019 · 4 comments
Closed

Misplaced page elements on theguardian.com #5675

btlechowski opened this issue Aug 15, 2019 · 4 comments
Labels
closed/works-for-me priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Test-Plan-Specified QA/Yes webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@btlechowski
Copy link

btlechowski commented Aug 15, 2019

Original report: https://community.brave.com/t/messes-up-top-menu-strange-indenting-or-paragraphs-and-site-wont-load/75254

Note: theguardian.com is a verified publisher

Steps to Reproduce

Note: the reproducibility of this issue depends on viewport size.

  1. Open https://www.theguardian.com/uk/lifeandstyle
  2. Resize browser window (I resized to 1116x543)
  3. Click More in the top navigation bar few times.
  4. Repeat 2 and 3

theguardian

Note: turning off shields didn't fix the issue

Actual result:

the text in the menu overlaps
image

Expected result:

The text in the menu does not overlap
image

Reproduces how often:

Depends on viewport resolution.

Brave version (brave://version info)

Brave 0.68.129 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 7 Service Pack 1 (Build 7601.24494)
Brave 0.71.5 Chromium: 76.0.3809.100 (Official Build) nightly (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Not reproducible in Chrome: 76.0.3809.100 (Official Build) (64-bit)

cc @brave/legacy_qa @ryanbr

@btlechowski btlechowski added webcompat/not-shields-related Sites are breaking because of something other than Shields. QA/Yes QA/Test-Plan-Specified labels Aug 15, 2019
@ryanbr
Copy link

ryanbr commented Aug 16, 2019

I wonder if its similar to reflow breakage reported on yahoo #5643

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 23, 2019
@ryanbr
Copy link

ryanbr commented Mar 7, 2020

Hey @btlechowski I just re-tested in Brave-Release 1.4.96, seems to be better? Also tested in Nightly (which seemed to have smoother reflow). Has it been fixed?

@ryanbr
Copy link

ryanbr commented Jul 10, 2020

Closing ticket, site renders fine in Brave release.

@ryanbr ryanbr closed this as completed Jul 10, 2020
@btlechowski
Copy link
Author

Thanks @ryanbr. Looks good.

Verification passed on

Brave 1.12.82 Chromium: 84.0.4147.68 (Official Build) beta (64-bit)
Revision e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS Windows 7 Service Pack 1 (Build 7601.24544)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/works-for-me priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Test-Plan-Specified QA/Yes webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

No branches or pull requests

3 participants