Assertion on startup when using old ads history JSON data

[emerick]

@tmancey mentioned that the ads history related changes are throwing an assertion with his profile due to a JSON-related problem. Upon investigating, noticed that the old ads_shown_history format was an array of timestamps (vs. the new format which is an array of objects). Unfortunately, document.Parse wasn't returning an error and instead a later call to HasMember was asserting.

Spoke with @tmancey and we decided to just look explicitly for a uint64_t and, if found, move on to the next member (as it was always expected that a user's ad history would reset with this upgrade anyway).

[btlechowski]

@emerick This issue is set to QA/Blocked. I am not sure why. If it is something that can not be tested by QA, just add QA/No label.

[emerick]

@btlechowski Sorry, must have hit the wrong tag - fixed now!

[GeetaSarvadnya]

Verification passed on

Brave	0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Ignore old ads shown history data and start over fresh brave-core#3152

old profile which has ads_shown_history

Launched old profile and viewed an ad in new launch removed old profile ads_shown_history

Open an old profile is removing Ads panel. Unable to test ads panel ads viewed data in the panel due to #6148.

Verification passed on

Brave	0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Ubuntu 18.04 LTS

• Verified the test plan from Ignore old ads shown history data and start over fresh brave-core#3152

0.68.x profile which has ads_shown_history after viewing 1 ad
Verified ads_shown_history is present

Verified 1 ad viewed in brave://rewards

Upgraded Brave to 0.69.x and viewed an ad.
Verified ads_shown_history was removed and not assertion is thrown

Verified 2 ads viewed in brave://rewards

Verified passed with

Brave	0.69.131 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Ignore old ads shown history data and start over fresh brave-core#3152
  adsShownHistory from 0.68.x (note, one of my views on 0.68.x encountered Fix 503 response not adding confirmation to queue to be retried #5599 so it was lost. This issue is fixed in 0.69.x):

Upgraded to 0.69.x:

Verified Ads panel shows same info from 0.68.x:

When an Ad was served after upgrade, this is how adsShownHistory was populated:

Ads panel incremented as expected: