Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript (.ts and .tsx) files have no syntax highlighting when opened in the dev tools Sources tab #5618

Closed
tamj0rd2 opened this issue Aug 11, 2019 · 8 comments
Labels
feature/dev-tools priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include

Comments

@tamj0rd2
Copy link

tamj0rd2 commented Aug 11, 2019

Description

I'm developing a website using Typescript. When I open the dev tools, go to the Sources tab and click any .ts or .tsx files, there is no syntax highlighting.

Steps to Reproduce

Requires node/npm to be installed

  1. Run npx create-react-app myappname --typescript
  2. cd myappname
  3. npm start
  4. Open localhost:3000 in brave
  5. Go to DevTools > Sources tab
  6. Open index.tsx or any other ts/tsx file

Actual result:

No syntax highlighting although the debugger still works

image

Expected result:

Syntax highlighting, shown in Chrome

image

Reproduces how often:

Easily reproduced. I've never seen it working correctly

Brave version (brave://version info)

Brave 0.67.124 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1809 (Build 17763.615)

Chrome for comparison:

Google Chrome 76.0.3809.100 (Official Build) (64-bit) (cohort: Stable)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1809 (Build 17763.615)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Not tried
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Not tried

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. feature/dev-tools labels Aug 16, 2019
@rebron
Copy link
Collaborator

rebron commented Aug 16, 2019

Possibly blocking a script from Google that's doing the styling.

@tamj0rd2
Copy link
Author

tamj0rd2 commented Aug 16, 2019

But I would think that whatever's responsible for providing syntax highlighting for files in the devtools would be shipped with Brave? It doesn't seem like something an external script would need to be downloaded for

@ksbrar
Copy link

ksbrar commented Aug 20, 2019

Bump.

@rguillaume
Copy link

That would be great

@alexichepura
Copy link

This stopped me as a web developer to use brave as main browser. Three times =(

@bsclifton
Copy link
Member

This may be fixed now; with Nightly (and it'll work its way down through channels), you can enable remote debugging under brave://settings/privacy. When this is enabled, it should fetch sources

@ksbrar @rguillaume @alexichepura and others: can you please try Nightly and confirm it works? (with Remote Debugging enabled?)

@bsclifton bsclifton added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Dec 2, 2019
@alexichepura
Copy link

alexichepura commented Dec 3, 2019

@bsclifton thanks for the update! It works for me in nightly after enabling remote debugging and browser restart.

@bsclifton
Copy link
Member

bsclifton commented Dec 3, 2019

Closing as this is fixed with brave/brave-core#4044

Thanks for the confirmation, @alexichepura! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/dev-tools priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
None yet
Development

No branches or pull requests

6 participants