Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling content level tips for Reddit doesn't remove tip button from in-line menu until page refresh #5551

Closed
LaurenWags opened this issue Aug 6, 2019 · 3 comments
Labels
bug feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Aug 6, 2019

Description

When you disable content-level tips for Twitter, after a few seconds the tip button is removed from the in-line menu. If you do this for Reddit, the tip button doesn't go away until you refresh the page.

Steps to Reproduce

  1. Clean profile
  2. Enable Rewards
  3. Visit reddit
  4. See tip button in the in-line menu.
  5. Open brave://rewards in a new tab and disable content level tips for Reddit.
  6. Go back to reddit page and wait. In-line tip button is never removed.
  7. Refresh page. Now in-line tip button is removed.
  8. Go back to brave://rewards and enable content level tips for Reddit.
  9. Go back to reddit page and wait. In-line tip button appears after a few seconds.
  10. Also occurs on old.reddit.com.

This works as expected for Twitter content level tips.

Actual result:

Need to refresh Reddit to remove content level tips after they are disabled.
disblereddittips

Expected result:

Should behave as Twitter does (no need to refresh page):
disabletwittertips

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X
Brave 0.69.99 Chromium: 76.0.3809.87 (Official Build) dev (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure but probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@hmert
Copy link

hmert commented Oct 10, 2020

I've same issue.
#12040

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 14, 2021

I'm surprised the tip buttons disappear after a page refresh. Historically, a browser restart was required to get the setting to actually take effect. Perhaps the expectation here has changed? Otherwise, if restarting browser solves issue, then it's working as expected.

Instead, we would just surface a modal or notification banner that tells the user they need to restart browser in order for changes to take effect.

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 4, 2023

It now prompts for browser restart.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants