Exception rules in brave://adblock or regional lists are ignored

[pes10k]

Currently exception rules added in brave://adblock and in regional lists are ignored, because of how filter logic is applied (main set of rules is queried, then regional, then custom, in order, until one of them has a match). This means an exception in a later list won't correctly except a rule from a previous set, and that important wont override an exception from a previous set.

[ryanbr]

@antonok-edm do we have an update on this?

[pes10k]

@antonok-edm isn't currently working on this, so we'll need to figure out internally whats best here.

I believe @bbondy and @AndriusA had a plan for tagging rules so that they could all be part of a single engine, of having the layered engines (which is what causes the issue). When either of you have a chance, could you say if the above (tag the rules) approach is still the official plan of action, and if so, if anyone is currently working on it (or if its in the backlog)?

[AndriusA]

the last I know of this is a conversation with @antonok-edm where we discussed a couple of approaches and their trade-offs and agreed that he'd post it up for discussion

[pes10k]

@antonok-edm i know you're working on other things at the moment, but could you just update the issue here with where the conversation ended (if a conclusion was reached) and we'll figure out how best to go forward

[stephendonner]

Verified FIXED using the testplan from brave/brave-core#7666 on

Brave	1.21.47 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	macOS Version 11.2 (Build 20D64)

Case 1: defaults Shields settings, https://knowyourmeme.com - NO ad(s)

Case 2: default Shields settings, https://knowyourmeme.com, added @@*$domain=knowyourmeme.com to the Custom Filters section in brave://adblock - 1 ad (bottom of the page)

---

Verification passed on

Brave	1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7666

Before custom rule	After custom rule

---

Verification passed on

Brave | 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Verified test plan from brave/brave-core#7666

Before custom rule	After custom rule

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.21.64 x64 beta build

• Verified test plan from Support exception rules in the custom filters box of brave://adblock brave-core#7666

Default shields (no exception rule)	Exception rule in chrome://adblock