Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please implement a cookie banner blocker that works like "I don't care about cookies" #5318

Closed
szaimen opened this issue Jul 22, 2019 · 32 comments · Fixed by brave/adblock-rust#82 or brave/brave-core#5117
Assignees
Labels
feature/cookies priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include suggestion

Comments

@szaimen
Copy link

szaimen commented Jul 22, 2019

Please implement a cookie banner blocker that works like "I don't care about cookies"
Official Website: https://www.i-dont-care-about-cookies.eu/
I think the consent policy for installing cookies is also really nice.
Look here: https://www.i-dont-care-about-cookies.eu/notices/3.0.2/
and here: https://www.i-dont-care-about-cookies.eu/cookie-installing-permission-header/

@ryanbr
Copy link

ryanbr commented Jul 23, 2019

I don't care about cookies isn't that optimised. But it would be handy to block cookie notices as an option.

@szaimen
Copy link
Author

szaimen commented Jul 25, 2019

I don't know, if it's optimized or not, but in my experience especially the chrome extension works really well! The best thing about this extension is, that I do not have to make script blocking in brave to the default (to block all cookie notices), because it just destroys most of the websites I visit.

BTW: this chrome extension is available under GPL 3.0 as stated inside the license-file in the extension-folder.

@rebron
Copy link
Collaborator

rebron commented Aug 9, 2019

@snyderp can you take a look at triaging this one?

@pes10k pes10k added the priority/P4 Planned work. We expect to get to it "soon". label Aug 9, 2019
@rebron
Copy link
Collaborator

rebron commented Aug 12, 2019

cc: @anthonypkeane

@szaimen
Copy link
Author

szaimen commented Oct 5, 2019

Any update here? Would be really handy to get this option out of the box!

@BrendanEich
Copy link
Member

Stirring the pot on this with @ryanbr.

@ryanbr
Copy link

ryanbr commented Nov 5, 2019

@szaimen We're still investigating the possibility of using a cookie list. watch this space :)

https://github.com/easylist/easylist/tree/master/fanboy-addon

fanboy_cookie_general_block.txt
fanboy_cookie_general_hide.txt
fanboy_cookie_international_specific_block.txt
fanboy_cookie_international_specific_hide.txt
fanboy_cookie_specific_block.txt
fanboy_cookie_specific_hide.txt
fanboy_cookie_thirdparty.txt
fanboy_cookie_whitelist.txt
fanboy_cookie_whitelist_general_hide.txt

Official link; https://easylist-downloads.adblockplus.org/fanboy-cookie.txt

@pes10k
Copy link
Contributor

pes10k commented Nov 5, 2019 via email

@rebron
Copy link
Collaborator

rebron commented Nov 5, 2019

Requires: #5381

@pes10k
Copy link
Contributor

pes10k commented Nov 6, 2019

@anthonypkeane

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 9, 2019
@rebron rebron self-assigned this Nov 19, 2019
@Brave-Matt
Copy link

A couple +1s from Community:
https://community.brave.com/t/block-cookie-consent-popups-cookie-policy-is-already-set-locally-with-brave/98876/3

@ryanbr
Copy link

ryanbr commented Mar 18, 2020

+1
https://community.brave.com/t/block-cookie-banners/113665/2

@szaimen
Copy link
Author

szaimen commented Mar 30, 2020

🎉

@bsclifton
Copy link
Member

bsclifton commented Mar 31, 2020

Although a fix is merged with brave/adblock-rust#82, we have a few more steps before this is live in Brave:

cc: @AndriusA @ryanbr

edit: it's merged! 😄 Next Nightly build will have it. Stay tuned!

@bsclifton bsclifton reopened this Mar 31, 2020
@bsclifton
Copy link
Member

@ryanbr are there test steps that can be added to original post? What does QA look like for this?

@ryanbr
Copy link

ryanbr commented Mar 31, 2020

Functionality isn't changing from the previous list, just a supported list instead.

@bsclifton
Copy link
Member

bsclifton commented Mar 31, 2020

@kjozwiak @LaurenWags release notes for this could be Switch from "Prebake Cookie" to "Easylist Cookie" list. I didn't want to edit the original title 😄

@kjozwiak
Copy link
Member

kjozwiak commented Apr 1, 2020

@bsclifton yup, sounds good! Much appreciated.

@szaimen
Copy link
Author

szaimen commented Apr 1, 2020

🎉

@RichyHBM
Copy link

RichyHBM commented Jun 3, 2020

Hello, has this been implemented in the android browser? Or will it be coming to android?

@pes10k
Copy link
Contributor

pes10k commented Jun 4, 2020

@RichyHBM the list is being shipped on Android currently. So right now the network half of the list should be applied in all versions of the android browser.

The brave android browser doesn't currently apply cosmetic rules though, the way the desktop version of Brave does. This is bc the android version doesn't yet support extensions. Android support for extensions is currently being worked on, and we hope to have it good to go by the end of June, 2020

@rmaliqi
Copy link

rmaliqi commented Dec 30, 2020

where can I check if this function is available in my browser (windows and iOS)? I feel like I have to still click away those notifications all the time

@ryanbr
Copy link

ryanbr commented Jan 1, 2021

@rmaliqi windows (desktop) does support hiding cookie notices via brave://adblock , unfortantly iOS doesn't support cosmetic filter just yet which would limit its effectiveness.

Related to iOS:
brave/brave-ios#2683
brave/brave-ios#1358

@jakedavidson
Copy link

Has this been implemented in the Android browser yet? Just want to confirm as the last update had mentioned potentially shipping this in June, so want to make sure I didn't just miss it.

@RichyHBM the list is being shipped on Android currently. So right now the network half of the list should be applied in all versions of the android browser.

The brave android browser doesn't currently apply cosmetic rules though, the way the desktop version of Brave does. This is bc the android version doesn't yet support extensions. Android support for extensions is currently being worked on, and we hope to have it good to go by the end of June, 2020

@tbrodbeck
Copy link

I am still getting Cookie banners on macOS - banners that Adguard is able to block (Adguard Annoyances Filter).

I have tested this for example on this site: https://www.cookiepro.com/knowledge/how-do-i-test-cookie-blocking-implementation/

@ryanbr
Copy link

ryanbr commented May 28, 2021

@tbrodbeck tested here: enabling Easylist cookie via brave://adblock Seems fine here.

https://gif.fanboy.co.nz/gif/test-cookiepro.gif

@tbrodbeck
Copy link

@tbrodbeck tested here: enabling Easylist cookie via brave://adblock Seems fine here.

https://gif.fanboy.co.nz/gif/test-cookiepro.gif

Thanks! That works. Maybe there was some interference because I had all the other annoyances filters activated as well?!

@bartosz-jarmuz
Copy link

For me it does not work on that very same site.

@alfredonodo
Copy link

Brave just released Blocking annoying and privacy-harming cookie consent banners. However, it works in the same way as ublock origin via a filter list (Easylist-Cookie List - Filter Obtrusive Cookies Notice) and it does not work on google website (search, youtube, etc.).
In this case, an extension like I still don't care about cookies (a fork of I don't care about cookies recently acquired by avast) is still needed. Would it be possible for brave to implement something similar?

@pes10k
Copy link
Contributor

pes10k commented Sep 29, 2022

hi @alfredonodo , let me ping @ryanbr who does most of the filter list work at Brave (and does a great job doing it).

I just wanted to note though that we decided to not go with the "I {still} don't care about cookies" approach in general because its less privacy-protecting than the filter list approach. There are some cases though that won't work with the filter list approach (at least, not easily) for compat reasons. This might be one of them. We'll see what can be done using Brave's approach for the google example you mentioned and get back to you. Thanks for raising the issue!

@ryanbr
Copy link

ryanbr commented Sep 29, 2022

@alfredonodo investigating some snippet options regarding google/youtube. Not easy with standard filter options. IDCAC filterlist has the same issue. #25716

@alfredonodo
Copy link

Unfortunately, according to this, at the moment there is no solution.Unfortunately, based on this, there is currently no solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment