Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields panel doens't shrink to fit when advance options is hidden #53

Closed
srirambv opened this issue Jan 15, 2018 · 2 comments · Fixed by brave/brave-extension#41
Closed

Shields panel doens't shrink to fit when advance options is hidden #53

srirambv opened this issue Jan 15, 2018 · 2 comments · Fixed by brave/brave-extension#41
Assignees
@cezaraugusto
Labels
bug feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

shields-advcontrol
@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. labels Jan 15, 2018
@cezaraugusto cezaraugusto self-assigned this Jan 17, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #53 from brave/fix/88
18e3ab3 
fix native messaging dir for extensions that expect Google/Chrome (1p…
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 6, 2018
@bbondy
Copy link
Member

bbondy commented Jun 6, 2018

If spending more than a day on this, I'd just remove the advanced collapsable feature.

@cezaraugusto cezaraugusto mentioned this issue Jun 12, 2018
Merged
@cezaraugusto cezaraugusto mentioned this issue Jul 2, 2018
Merged
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 2, 2018
@cezaraugusto
fix shields nor shrinking when advanced opt is hidden
dba1d6a 
fix brave/brave-browser#53
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2018 •
edited by LaurenWags
Loading

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows
JavaScript V8 6.9.427.14
Flash 30.0.0.154

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
@iefremov iefremov mentioned this issue Nov 27, 2020
Closed
@bridiver bridiver mentioned this issue Mar 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix shields nor shrinking when advanced opt is hidden brave/brave-extension
5 participants
@bbondy @cezaraugusto @srirambv @LaurenWags @GeetaSarvadnya