Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave version gen not building with fresh build #526

Closed
bbondy opened this issue Jul 12, 2018 · 0 comments
Closed

Brave version gen not building with fresh build #526

bbondy opened this issue Jul 12, 2018 · 0 comments
Assignees
Labels

Comments

@bbondy
Copy link
Member

bbondy commented Jul 12, 2018

At least on Linux:

garrettr@ubuntu:~/brave$ yarn build
yarn run v1.7.0
$ node ./scripts/commands.js build
touch original files overridden by chromium_src...
<snip>
building brave...isystem../../buildtools/third_party/libc++abi/trunk/include --sysroot=../../build/linux/debian_sid_amd64-sysroot -fvisibility-inlines-hidden -c ../../brave/browser/version_info_values.cc -o obj/brave/browser/browser_process/version_info_values.o
In file included from ../../brave/browser/version_info_values.cc:5:
../../brave/browser/version_info_values.h:9:10: fatal error: 'brave/version.h' file not found
#include "brave/version.h"
         ^~~~~~~~~~~~~~~~~
1 error generated.
[2290/13166] CXX obj/third_party/blink/public/mojom/mojom_core_blink/service_worker.mojom-blink.o
ninja: build stopped: subcommand failed.

Regressed here:
brave/brave-core#237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant