-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardware wallet connection notification uses Chromium icon #5058
Comments
Could be similar to #5008 but that is on Windows 8.1 |
@rossmoody @petemill I think this can be fixed by replacing |
Moved this into the |
I don't seem to get a notification on macOS, is this one Windows only? |
Dont think this is platform specific |
Maybe @kjozwiak can check his mac, but I don't get any kind of notification on mine when connecting a hardware wallet - so I can't check this one. |
Verification PASSED on
Verification passed on
Verification passed on
Windows doesnt show the same notification via the browser. System notification shows the device setup |
Description
Found while verifying #4669. Connecting Trezor and visiting https://wallet.trezor.io, system shows the USB connection info for the browser which uses a Chromium icon
Steps to Reproduce
0.66.x
buildActual result:
Expected result:
Should use Brave icon for branding
Reproduces how often:
Somewhat easy if you know what you are doing
Brave version (brave://version info)
Noticed it on
0.66.98
but pretty sure its in all supported versionVersion/Channel Information:
0.66.x
goes to release0.66.x
was in betaOther Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: