Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid shortcut path and displayed name of installed pwa #4701

Closed
simonhong opened this issue Jun 4, 2019 · 1 comment · Fixed by brave/brave-core#2617
Closed

Invalid shortcut path and displayed name of installed pwa #4701

simonhong opened this issue Jun 4, 2019 · 1 comment · Fixed by brave/brave-core#2617

Comments

@simonhong
Copy link
Member

simonhong commented Jun 4, 2019

After creating shortcuts, pwa app (by using nightly) is installed in ~/Applications/Chrome Canary Apps.localized dir. and displayed as Brave Apps like below.

Shortcuts by nightly can be overwritten by Chrome canary browser because they are created in Chrome Canary Apps.localized folder.

Shortcuts by others are all in same Chrome Apps folder. And shortcuts from same site can be overwritten because they all are created in Chrome Apps.localized folder.
Also, they all can be overwritten by Chrome browser.

Screen Shot 2019-06-04 at 3 42 31 PM

This should be ~/Applications/Brave Browser Nightly Apps.localized in filesystem and displayed like Brave Browser Nightly Apps for Nightly.

STR:

  1. Create shortcuts from app menu
  2. Check its path in terminal and finder
  3. It's path should be Brave Browser XXX Apps.localized in terminal and Brave Browser XXX Apps in finder in en_us locale.
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.66.89 Chromium: 75.0.3770.87 (Official Build) beta(64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Mac OS X

Ensured that creating shortcuts placed them under the following directory:

Kamils-MBP:Brave Browser Beta Apps.localized kjozwiak$ pwd
/Users/kjozwiak/Applications/Brave Browser Beta Apps.localized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment