follow up - CDM utility process not starting when tab triggers Widevine install in new profile

[btlechowski]

Follow up to #4604
The automatic reload implemented in brave/brave-core#2514 does not fix the issue on Windows

Description

Unable to stream Netflix on a clean profile. Works on Release channel.

Test plan / Steps to Reproduce

1. Clean profile
2. Navigate to netflix.com and login.
3. Enable widevine and try to stream something.

Note - fixes after manual page reload

Actual result:

The automatic reload implemented in brave/brave-core#2514 is triggered.
Widevine component is not updated

Expected result:

Able to stream Netflix.

Reproduces how often:

easily

Brave version (brave://version info)

Brave	0.65.114 Chromium: 75.0.3770.38 (Official Build) (64-bit)
Revision	3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS	Windows 10 OS Version 1803 (Build 17134.765)

cc @brave/legacy_qa @rebron @simonhong @bsclifton

[simonhong]

I think this can be happen because reloading is requested right after requesting install widevine.
This should be improved like this - reloading after widevine component install is finished.
This can be happened on MacOS also.

 void EnableWidevineCdmComponent(content::WebContents* web_contents) {
  DCHECK(web_contents);

  PrefService* prefs = ProfileManager::GetActiveUserProfile()->GetPrefs();
  if (prefs->GetBoolean(kWidevineOptedIn))
    return;

  prefs->SetBoolean(kWidevineOptedIn, true);
  RegisterWidevineCdmComponent(g_brave_browser_process->component_updater());
  ChromeSubresourceFilterClient::FromWebContents(web_contents)
      ->OnReloadRequested();
}

[GeetaSarvadnya]

The issue is Reproducible consistently on Windows 10 x64 - 0.65.114.

[bsclifton]

@GeetaSarvadnya do you know if the issue happens also with our current release version? (0.64.x?) Given that a refresh fixes this, maybe we had never noticed before

NOTE: I ran into the same issue when testing brave/brave-core#2514... but when using Netflix's <- back button (in their UI - not the browser back button) and picking the same program again, it works 🤷‍♂

[kjozwiak]

I went through this a bit last night/today and got mixed results as well. It usually works pretty well but sometimes you'll still get the Missing Component message and you'll need to refresh the page or open a new tab. macOS x64 seems to be working a a lot smoother. @LaurenWags and myself confirmed that we're not getting the Missing Component message anymore via #4604. But on Win, there's maybe some type of race condition that happens and the refresh doesn't happen in time?

NOTE: I ran into the same issue when testing brave/brave-core#2514... but when using Netflix's <- back button (in their UI - not the browser back button) and picking the same program again, it works.

It's pretty easy to recover from the error, you can usually do the following whenever you run into the above:

• refresh the Netflix page and the error goes away
• open a new tab and re-load Netflix
• restart the browser

[simonhong]

@kjozwiak I think it's not strange for getting Missing Component message after enabling widevine on MacOS and Windows both.
The reason is our current implementation is reloading request is issued right after requesting registering widevine. If widevine registering is completed synchronously, we can't see this. but it would be in async.

[simonhong]

If this is started to happen since C75 or 65.x, I'm not sure but I assume there would be some modification in component registration/update logic.(upstream side or our side..)

[simonhong]

I think we can fix this but seems not urgent issue for now because just reloading again can fix this :)

[kjozwiak]

I think we can fix this but seems not urgent issue for now because just reloading again can fix this :)

Agreed 100%. Really easy to fix by simply refreshing, opening a new tab or restarting the browser 👍

[GeetaSarvadnya]

#4646 (comment)

@bsclifton when the issue was raised, I have verified this issue on both 0.64.x and 0.65.x. I was unable to reproduce the issue consistently in 0.64.77, it was reproducible once in 4 attempts. Even @btlechowski was unable to reproduce the issue in 0.64.77 either. Today, I have tested it again the issue is Reproducible continuously in 0.64.x also.

https://bravesoftware.slack.com/archives/GAA4017R7/p1559197011001000?thread_ts=1559174016.115100&cid=GAA4017R7

[btlechowski]

@GeetaSarvadnya Thanks for checking. I tested few more times and was also able to repro the issue on 0.64.77.

[btlechowski]

Verification passed on

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Ubuntu 18.04 LTS

Verified Linux install steps still work

1. Install Widevine
   

2. Restart browser
   

3. Verified netflix streams without problems

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave | 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

• verified that Netflix, YT and DisneyPlus worked after installing Widevine
• ensured that Netflix, YT and DisneyPlus worked without any issues after restarting the browser
• ensured that the installation process still works without any issues

Verification passed on

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified that install Widevine works as expected
  
• Verified Netflix streams without any problems
• Verified Netflix worked without any issues after restarting the browser