Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert features to correct state after disabling field trials #4552

Closed
3 tasks done
jumde opened this issue May 23, 2019 · 1 comment · Fixed by brave/brave-core#2471
Closed
3 tasks done

Revert features to correct state after disabling field trials #4552

jumde opened this issue May 23, 2019 · 1 comment · Fixed by brave/brave-core#2471

Comments

@jumde
Copy link
Contributor

jumde commented May 23, 2019

Description

Follow-up issue to #4283

  • EV status should be set to lock instead of secure chip
  • Remove features from brave_main_delegate.cc that were enabled/disabled because of field trials
  • Set kExtensionsInstallVerification to enforce-strict for BravePDFDownloadTest.VerifyChromiumPDFExntension

Test Plan

Specified here: brave/brave-core#2471

@btlechowski
Copy link

btlechowski commented Jul 24, 2019

Verification passed on

Brave 0.68.109 Chromium: 76.0.3809.62 (Official Build) dev (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2471

Only Lock is displayed
image

Verification passed on

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

Verified passed with

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment