Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scriptlets wrapper given incorrect value for url comparison #43454

Open
5 tasks
StephenHeaps opened this issue Jan 23, 2025 · 0 comments · May be fixed by brave/brave-core#27320
Open
5 tasks

Scriptlets wrapper given incorrect value for url comparison #43454

StephenHeaps opened this issue Jan 23, 2025 · 0 comments · May be fixed by brave/brave-core#27320
Assignees
@StephenHeaps
Labels
bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality regression

Comments

@StephenHeaps
Copy link

Description

Ads are displaying on YouTube for some videos

Steps to reproduce

  1. Play some YouTube videos with Shields up (signed out seemed to have better luck)
  2. Verify no ads shown, or metadata shown (0:00/0:06 / 0:00:0:15 timestamps shown before video plays)

Actual result

Ads or ad metadata slips through

Expected result

No ads

Reproduces how often

Easily reproduced

Brave version

1.69 (71)+

Device/iOS version

Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@StephenHeaps StephenHeaps added bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality regression labels Jan 23, 2025
@StephenHeaps StephenHeaps self-assigned this Jan 23, 2025
@StephenHeaps StephenHeaps linked a pull request Jan 23, 2025 that will close this issue
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenHeaps StephenHeaps

Labels
bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(privacy): FrameCheckWrapper.js given incorrect value for url comparison brave/brave-core
1 participant
@StephenHeaps