Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename donation(s) to tip(s) #4345

Closed
NejcZdovc opened this issue May 8, 2019 · 0 comments · Fixed by brave/brave-core#2388
Closed

Rename donation(s) to tip(s) #4345

NejcZdovc opened this issue May 8, 2019 · 0 comments · Fixed by brave/brave-core#2388

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 8, 2019

When we start rewards project we wanted to add donations. But at the later stage this name was changed to tips. Because of that we have both usage in the code. To unify the code we would like to rename all donation(s) mentions into tip(s). There was already first step made into this direction with this issue #3953. Second step(this issue) needs to be more aggressive where we need to rename files and variables. Next step (follow up to this issue) is migrate state values to new naming convention. Last step is to update brave-ui repo so that we remove donation mention from there as well.

For this issue:

  • rename all files that contain donation phrase to tip
  • find all variables, class names, definitions, etc. that contain donation phrase and rename it to tip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants