Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve font appearance for non-english characters #4309

Closed
ademaro opened this issue May 5, 2019 · 13 comments · Fixed by brave/brave-core#12933
Closed

Improve font appearance for non-english characters #4309

ademaro opened this issue May 5, 2019 · 13 comments · Fixed by brave/brave-core#12933
Assignees
@boocmp
Labels
design A design change, especially one which needs input from the design team l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@ademaro
Copy link

ademaro commented May 5, 2019

Description

Why you do not use utf-8 fonts for UI? https://yadi.sk/i/LgsPsXybFLfUqQ — no good!
https://yadi.sk/i/9Z-U76fYU4VkEg — cyrillic no good!!

Steps to Reproduce

  1. Open browser

Actual result:

Bad font rendering.

Expected result:

Good font rendering.

Brave version (brave://version info)

Brave 0.63.48 Chromium: 74.0.3729.108 (Официальная сборка) (64 бит)
Версия daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
ОС Mac OS X

Other Additional Information:

  • Is the issue reproducible on the latest version of Chrome? No
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. l10n labels May 10, 2019
@rebron
Copy link
Collaborator

rebron commented May 10, 2019

cc: @rossmoody

@rebron rebron changed the title Ugly font if no latin improve font appearance with non-english characters May 10, 2019
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels May 10, 2019
@alshenetsky
Copy link

I am so tired of this :(
image

Is there any progress guys?

@bsclifton
Copy link
Member

cc: @karenkliu @rebron

@bsclifton bsclifton added the design A design change, especially one which needs input from the design team label Aug 6, 2021
@iamalexei
Copy link

iamalexei commented Nov 4, 2021 •
edited
Loading

The Poppins font used for the UI doesn't support Cyrillic symbols

Settings page:
brave 2021-11-05 005704

brave-browser-shield-settings

Private window:
brave-private-ru

brave-private-en

@iefremov
Copy link
Contributor

People on the Russian blog also ask to fix this. Can you please triage @bradleyrichter ? Thanks

@rebron rebron self-assigned this Nov 23, 2021
@bradleyrichter
Copy link

@jenn-rhim for a Cyrillic compatible Poppins alternative...

@ademaro
Copy link
Author

ademaro commented Feb 22, 2022

Is it really so difficult to connect a second font for Cyrillic? Add at least Open Sans as a second font. Issue has been open for many years...

@jenn-rhim
Copy link

jenn-rhim commented Mar 4, 2022 •
edited
Loading

Have determined a font replacement of Poppins to support Cyrillic alphabets to be 'Manrope'.
Evaluation and screen testing is located here:
https://www.figma.com/file/y2jrcOMPbctWsPCI8UY8fP/Cyrillic-Font-tests?node-id=11%3A2

private ntp - Russian

Thanks to @aguscruiz. cc: @rebron @petemill

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Mar 15, 2022
@iefremov
Copy link
Contributor

iefremov commented Apr 1, 2022

@jenn-rhim do I understand correctly we completely replace Poppins with Manrope across the browser? I've seen in Figma that texts in bolds are pretty different with Poppins vs Manrope.

@boocmp boocmp self-assigned this Apr 2, 2022
This was referenced Apr 7, 2022
Closed
Merged
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 21, 2022
@LaurenWags
Copy link
Member

@petemill could you please provide a test plan for this one? Marking as QA/Blocked for now 👍🏻

cc @rebron @kjozwiak

@boocmp
Copy link

boocmp commented Nov 8, 2022 •
edited
Loading

@LaurenWags

Launch the browser in Cyrillic (by passing --lang=ru_RU in the command line or by changing the system language)

In the settings, check DevTools resources/fonts/poppins.css. It should actually refer to the manrope font instead of poppins.
It is the main check.
Manrope

Check the screenshots, they should look the same. Just to be sure we have load manrope.

(brave://settings)
Settings_get_started

(brave://history)
Brave_history

(brave://rewards)
Brave_rewards

(brave://wallet)
Brave_wallet

(Incognito window)
Incognito

(NTP)
NTP

@diracdeltas diracdeltas mentioned this issue Nov 9, 2022
Closed
@LaurenWags
Copy link
Member

great, thanks @boocmp! we will look on this one shortly 👍🏻

@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 10, 2022 •
edited
Loading

Verification PASSED using

Brave | 1.46.102 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
-- | --
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS | Windows 11 Version 21H2 (Build 22000.1219)
  • Install 1.46.102
  • launch Brave with --lang=ru_RU in the command line
  • opened brave internal pages as below
  • opened hamburger menu>>More tools>>Developer tools>>resources>>fonts>>poppins.css.

Confirmed manrope font was referred.

normal window

before fix (1.45.123) brave://settings/appearance Brave://settings brave://history
image image image image

normal window

brave://rewards brave://wallet NTP
image image image

private window

image

@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 10, 2022
@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
@rebron rebron changed the title improve font appearance with non-english characters Improve font appearance for non-english characters Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boocmp boocmp

Labels
design A design change, especially one which needs input from the design team l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.46.x - Release