Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable self-reported webcompat issues when Shields is DOWN #4262

Closed
karenkliu opened this issue Apr 27, 2019 · 1 comment · Fixed by brave/brave-core#3420
Closed

Enable self-reported webcompat issues when Shields is DOWN #4262

karenkliu opened this issue Apr 27, 2019 · 1 comment · Fixed by brave/brave-core#3420
Assignees
Labels

Comments

@karenkliu
Copy link

karenkliu commented Apr 27, 2019

Description

Users may be turning off Shields in response to running into webcompat issues. Help speed up webcompat improvement in Shields by allowing the user to self-report issues when running into them.

Designs

Add a "Report a broken site" button that allows the user to self-report issues on the Shields DOWN state:

shields off 1

Clicking on "Report a broken site" will ask the user for permission to send information to Brave:

shields off 2

Clicking on "Submit" will flag that site for the webcompat team and give feedback to the user:

shields off 3

Shields should remember that the user has previously flagged a site for a webcompat issue. In this case, the Shields DOWN state will not have a "Report a broken site" button and instead persist the thank you message.

shields off 4

The list of flagged webcompat sites will reset when a user relaunches a new browser binary (the UP/DOWN state will be retained.)

User flow:
user flow - selfreport webcompat issue

@kjozwiak
Copy link
Member

kjozwiak commented Jan 15, 2020

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)
  • ensured that the Report a broken website button doesn't appear when shields are enabled
  • ensured that the Report a broken website button is being displayed when shields are disabled
  • ensured that the Report a broken site displays the correct website that's being submitted
  • ensured that that clicking on Cancel closes the Report a broken site modal
  • ensured that clicking on Submit correctly displays the Thank You! modal
  • ensured that the Thank You! modal is automatically dismissed
  • ensured that clicking on Submit correctly submits the data via the terminal

[47434:775:0114/225922.814119:INFO:webcompat_report_uploader.cc(91)] Successfully uploaded webcompat report. Thanks!

Examples of the UI under macOS:

Screen Shot 2020-01-14 at 6 17 49 PM

Screen Shot 2020-01-14 at 6 18 33 PM

Screen Shot 2020-01-14 at 6 18 50 PM

Screen Shot 2020-01-14 at 6 19 39 PM

Screen Shot 2020-01-14 at 6 21 01 PM

Screen Shot 2020-01-14 at 11 04 31 PM

Verification passed on

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that the Report a broken website button doesn't appear when shields are enabled
  • ensured that the Report a broken website button is being displayed when shields are disabled
  • ensured that the Report a broken site displays the correct website that's being submitted
  • ensured that that clicking on Cancel closes the Report a broken site modal
  • ensured that clicking on Submit correctly displays the Thank You! modal
  • ensured that the Thank You! modal is automatically dismissed
  • ensured that clicking on Submit correctly submits the data via the terminal

[27008:8324:0115/165846.133:INFO:webcompat_report_uploader.cc(91)] Successfully uploaded webcompat report. Thanks!
UI for Windows
image
image
image
image
image
image

Verification passed on

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Ubuntu 18.04 LTS
  • ensured that the Report a broken website button doesn't appear when shields are enabled
  • ensured that the Report a broken website button is being displayed when shields are disabled
  • ensured that the Report a broken site displays the correct website that's being submitted
  • ensured that that clicking on Cancel closes the Report a broken site modal
  • ensured that clicking on Submit correctly displays the Thank You! modal
  • ensured that the Thank You! modal is automatically dismissed
  • ensured that clicking on Submit correctly submits the data via the terminal

image
image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants