Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields count doesn't stop counting #426

Closed
srirambv opened this issue Jun 26, 2018 · 3 comments
Closed

Shields count doesn't stop counting #426

srirambv opened this issue Jun 26, 2018 · 3 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@srirambv
Copy link
Contributor

Description

Shields count doesn't stop counting

Steps to Reproduce

  1. Visit any site which has lot of ads/trackers
  2. Keep the page active for a while
  3. Blocked count keeps increasing

Actual result:

image

Expected result:

Should only show the blocked items and not increase the count on page

Reproduces how often:

100%

Brave version (about:brave info)

Release and packaged version
@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. labels Jun 26, 2018
@srirambv srirambv added this to the Releasable builds milestone Jun 26, 2018
@srirambv
Copy link
Contributor Author

Looks somewhat fixed on master(3924de4). Visiting http://www.espn.com/espn/feature/story/_/id/24340372/cristiano-ronaldo-probably-most-gifted-athlete-history-world-why-hard-complicated-writes-brian-phillips and clicking on video the shields count keeps increasing but not at the rate of reaching 4 digits like originally reported.

@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.x Backlog Sep 3, 2018
@bbondy
Copy link
Member

bbondy commented Sep 3, 2018

Moved to backlog since it is less severe now.

@srirambv srirambv mentioned this issue Oct 25, 2018
Closed
@tildelowengrimm tildelowengrimm added priority/P5 Not scheduled. Don't anticipate work on this any time soon. design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. labels Oct 31, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Nov 2, 2018

Closing in favour of #1311 which covers in depth

@srirambv srirambv closed this as completed Nov 2, 2018
@srirambv srirambv added closed/duplicate Issue has already been reported and removed bug design A design change, especially one which needs input from the design team feature/shields The overall Shields feature in Brave. feature/shields/panel Front-end design and functionality of the Shields panel. priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 2, 2018
@srirambv srirambv modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Nov 2, 2018
@sdpolke sdpolke mentioned this issue Dec 24, 2018
Closed
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
@snyk-bot snyk-bot mentioned this issue Jan 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tildelowengrimm @bbondy @yrliou @srirambv