Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads not enabled by default when joining Rewards from panel #4156

Closed
LaurenWags opened this issue Apr 18, 2019 · 1 comment · Fixed by brave/brave-core#2266
Closed

Ads not enabled by default when joining Rewards from panel #4156

LaurenWags opened this issue Apr 18, 2019 · 1 comment · Fixed by brave/brave-core#2266

Comments

@LaurenWags
Copy link
Member

Description

When joining Rewards from panel, Ads are not enabled. However, if you join Rewards from brave://rewards page, Ads are enabled.

Steps to Reproduce

  1. Clean profile, install 0.65.67 nightly build
  2. Click on BAT logo and join rewards from Panel.
  3. Look for ads related files in profile directory, there are none.
  4. Navigate to brave://rewards, see that Ads are toggled off.

Actual result:

Ads are toggled off.

Expected result:

Ads should be on.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.65.67 Chromium: 74.0.3729.75 (Official Build) nightly(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

If you repeat STR but join from brave://rewards, then Ads are toggled on.

cc @brave/legacy_qa

@ryanml ryanml self-assigned this Apr 18, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 18, 2019
@ryanml ryanml added this to the 0.65.x - Nightly milestone Apr 18, 2019
@jsecretan jsecretan added priority/P1 A very extremely bad problem. We might push a hotfix for it. release/blocking and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 18, 2019
@LaurenWags
Copy link
Member Author

LaurenWags commented Apr 22, 2019

Verified passed with

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X

Verification PASSED on macOS 10.14.14 x64 using the following build:

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment