Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Greaselion after Rewards stop using it #40873

Open
atuchin-m opened this issue Sep 5, 2024 · 1 comment · May be fixed by brave/brave-core#26283
Open

Remove Greaselion after Rewards stop using it #40873

atuchin-m opened this issue Sep 5, 2024 · 1 comment · May be fixed by brave/brave-core#26283
Assignees
Labels

Comments

@atuchin-m
Copy link
Contributor

Description

After brave/brave-core#25394 is merged and the new feature is considered as launched we don't need Greaselion code anymore.
The overlay idea of Greaselion is good, but the implementation is limited and has the number of issues:

  1. slows down the startup
  2. make a scoped_temp_dir folder in user-data-dir
  3. user a number of extension instead of a one
  4. doesn't support android

If we really need this feature is should be reimplemented.

@atuchin-m
Copy link
Contributor Author

atuchin-m commented Sep 5, 2024

As the first step Greaselion should be disabled for the most of Brave users: #40872

@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 11, 2024
@atuchin-m atuchin-m linked a pull request Oct 29, 2024 that will close this issue
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants