Confirmation type dismiss is not recorded in confirmations.json file

[GeetaSarvadnya]

Description

When we tap Close in ads notification popup, the confirmation type event dismiss is not recorded in the confirmations.json file.

Steps to Reproduce

1. Clean profile 0.63.31
2. Enable rewards
3. Open brave.com or imdb.com
4. Keep the page idle for 15 secs
5. Move the cursor
6. Tap on Close in Ads notification popup
7. Navigate to profile folder rewards_service and open confirmations.json file

Actual result:

confirmation type dismiss is not recorded in confirmations.json file

Expected result:

confirmation type dismiss should be recorded in the confirmations.json file

Reproduces how often:

Always

Brave version (brave://version info)

Brave	0.63.31 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

Reproducible on current release: No

• Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? NA
• Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@brave/legacy_qa

[tmancey]

Dismiss works as expected from the Notification Centre, so issue is when the notification appears on the desktop.

[srirambv]

This is what I see on Dev build(0.64.37) on Linux. Console logs the following failure message

22828:22828:0405/074848.232507:WARNING:redeem_token.cc(406)] Failed to redeem token with 68148e86-7ff0-4e3c-bafb-3157bd01d062 creative instance id for dismiss
[22828:22828:0405/074848.232523:INFO:redeem_token.cc(412)] Retry 68148e86-7ff0-4e3c-bafb-3157bd01d062 creative instance id for dismiss
[22828:22828:0405/074848.232541:INFO:redeem_token.cc(416)] Added 68148e86-7ff0-4e3c-bafb-3157bd01d062 creative instance id for dismiss to the confirmations queue
[22828:22828:0405/074848.232565:INFO:confirmations_impl.cc(642)] Saving confirmations state

but confirmations.json records the entry for each dismiss

[tmancey]

@srirambv ^ the failure is due to error returned in URL request response. Please provide chrome-debug.log inside user profile directory, however I expect this was a network error.

Failed confirmations will retry every 5 + jitter minutes until successful.

[srirambv]

[22828:22828:0405/075417.693148:INFO:confirmations_impl.cc(642)] Saving confirmations state
[22828:22828:0405/075417.694175:INFO:confirmations_impl.cc(782)] Removed 68148e86-7ff0-4e3c-bafb-3157bd01d062 creative instance id for dismiss from the confirmation queue
[22828:22828:0405/075417.694194:INFO:confirmations_impl.cc(642)] Saving confirmations state
[22828:22828:0405/075417.695120:INFO:redeem_token.cc(424)] Successfully redeemed token with 68148e86-7ff0-4e3c-bafb-3157bd01d062 creative instance id for dismiss
[22828:22828:0405/075417.695186:INFO:confirmations_impl.cc(931)] No failed confirmations to retry

Just rechecked and there is successful confirmation of the same token being redeemed

[rebron]

cc: @kjozwiak see for macOS

[tmancey]

@GeetaSarvadnya I believe this is fixed by #5548 could you please retest

[GeetaSarvadnya]

@terry Issue is reproducible only in 0.63.x. In the latest versions issue is fixed and working fine. Verified a couple of releases 1.1.x and 1.2.x and 1.3.x. Hence closing the issue.