Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad categories should be calculated based upon segment name and top level of segment name #3922

Closed
tmancey opened this issue Mar 28, 2019 · 1 comment · Fixed by brave/brave-core#2111
Closed

Ad categories should be calculated based upon segment name and top level of segment name #3922

tmancey opened this issue Mar 28, 2019 · 1 comment · Fixed by brave/brave-core#2111
Assignees
@tmancey
Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.63.x - Release ...

Comments

@tmancey
Copy link
Contributor

tmancey commented Mar 28, 2019

Ad categories should be calculated based upon Segment name and top level of Segment name:

i.e.

"segments": [
  {
    "code": "b6O0KdkEyr",
    "name": "Sports"
  },
  {
    "code": "q5qPgp5KncWi",
    "name": "Technology & Computing-Unix",
  }

Sports
Technology & Computing
Technology & Computing-Unix
@tmancey tmancey added this to the 0.64.x - Nightly milestone Mar 28, 2019
@tmancey tmancey self-assigned this Mar 28, 2019
@jsecretan jsecretan added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 28, 2019
@tmancey tmancey added the QA/Yes label Mar 28, 2019
@tmancey tmancey mentioned this issue Mar 28, 2019
Merged
19 tasks
tmancey added a commit to brave/brave-core that referenced this issue Apr 1, 2019
@tmancey
Ad categories should be calculated based upon segment name and top le…
7712094 
…vel of segment name

fixes brave/brave-browser#3922
@tmancey tmancey modified the milestones: 0.64.x - Dev, 0.65.x - Nightly Apr 1, 2019
tmancey added a commit to brave/brave-core that referenced this issue Apr 2, 2019
@tmancey
Ad categories should be calculated based upon segment name and top le…
5f21d9e 
…vel of segment name

fixes brave/brave-browser#3922
tmancey added a commit to brave/brave-core that referenced this issue Apr 2, 2019
@tmancey
Ad categories should be calculated based upon segment name and top le…
9bd860e 
…vel of segment name

fixes brave/brave-browser#3922
This was referenced Apr 2, 2019
Merged
Merged
tmancey added a commit to brave/brave-core that referenced this issue Apr 3, 2019
@tmancey
Ad categories should be calculated based upon segment name and top le…
befc92a 
…vel of segment name

fixes brave/brave-browser#3922
tmancey added a commit to brave/brave-core that referenced this issue Apr 3, 2019
@tmancey
Ad categories should be calculated based upon segment name and top le…
c483987 
…vel of segment name

fixes brave/brave-browser#3922
@kjozwiak kjozwiak mentioned this issue Apr 12, 2019
Closed
This was referenced Apr 12, 2019
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Apr 18, 2019 •
edited by srirambv
Loading

Verification PASSED on macOS 10.14.4 x64 using the following build:

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Verification passed by Geeta on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
5 participants
@jsecretan @tmancey @kjozwiak @srirambv @btlechowski