Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux command line help needs updating for brave specific details #392

Closed
srirambv opened this issue Jun 21, 2018 · 4 comments · Fixed by brave/brave-core#1986
Closed

Linux command line help needs updating for brave specific details #392

srirambv opened this issue Jun 21, 2018 · 4 comments · Fixed by brave/brave-core#1986
Assignees
@bsclifton
Labels
branding OS/Linux QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.62.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 21, 2018 •
edited by bsclifton
Loading

Description

Linux command line help needs updating for brave specific details

Test plan / Steps to Reproduce

  1. Install packaged build
  2. Type brave-browser --help in terminal
  3. See help section details which needs rebranding

Actual result:

image

Expected result:

Should be branded for Brave Software

Brave version (about:brave info)

Packaged build

Additional Information

#212
cc: @bbondy
@srirambv srirambv added this to the Releasable builds milestone Jun 21, 2018
@bbondy
Copy link
Member

bbondy commented Jun 21, 2018

nice find

@srirambv
Copy link
Contributor Author

This needs a check on mac as well for command line launch. Didn't see anything like this for Windows.

@bbondy bbondy modified the milestones: Releasable builds, Backlog Jun 27, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@srirambv srirambv mentioned this issue Mar 18, 2019
Closed
@bsclifton
Copy link
Member

+1 from #3757

@bsclifton bsclifton self-assigned this Mar 18, 2019
bsclifton added a commit to brave/brave-core that referenced this issue Mar 18, 2019
@bsclifton
Update Linux app details to remove Google mentions
726633b 
Fixes brave/brave-browser#392
@bsclifton bsclifton mentioned this issue Mar 18, 2019
Merged
19 tasks
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 18, 2019
@kjozwiak kjozwiak mentioned this issue Mar 21, 2019
Closed
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 0.62.32 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

image

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

image

@kjozwiak kjozwiak mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
branding OS/Linux QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update Linux app details to remove Google mention brave/brave-core
4 participants
@bbondy @bsclifton @rebron @srirambv