Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation bar styling for Downloads manager not reflected in Private or Tor Window mode #3740

Closed
cndouglas opened this issue Mar 15, 2019 · 5 comments
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages closed/no-milestone feature/private-browsing priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@cndouglas
Copy link
Contributor

Description

The navigation bar at the top of the Downloads page (that shows Settings, Brave Rewards, History, Bookmarks, and Downloads) looks different when the Downloads page is viewed in a private window. This only applies to the Downloads page because the other pages may only be opened in a normal window.

Steps to Reproduce

  1. Open a new private window.
  2. Go to brave://downloads/.

Actual result:

The navigation bar has a solid blue background and uses a serif font.

Expected result:

The navigation bar should match the normal one with a pink/purple background and a sans-serif font.

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 0.63.9 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes, 0.63.9.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Not applicable.
  • Is the issue reproducible on the latest version of Chrome? Not applicable.

Additional Information

@bsclifton bsclifton added about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages feature/private-browsing labels Mar 19, 2019
@bsclifton
Copy link
Member

cc: @petemill

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 22, 2019
@rebron
Copy link
Collaborator

rebron commented Mar 22, 2019

Related to #3503.
This issue is showing up on Guest Windows and Tor Window (because it's set up a guest window). Private window is working properly as its showing settings in a normal window.

@rebron rebron changed the title Navigation bar on Downloads page looks different in a private window Navigation bar styling for Downloads manager not reflected in Private or Tor Window mode Oct 9, 2019
@rebron
Copy link
Collaborator

rebron commented Oct 9, 2019

Screen Shot 2019-10-09 at 11 47 33 AM

Still an issue with Downloads page. The other pages like settings and extensions are being redirected to normal window mode.

@petemill
Copy link
Member

This does not seems to be an issue anymore

@rebron
Copy link
Collaborator

rebron commented Jun 30, 2020

No longer an issue in Private or Tor Window mode.
Checked using:

Brave 1.11.77 Chromium: 83.0.4103.116 (Official Build) beta (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS macOS Version 10.16 (Build 20A4299v)

Screen Shot 2020-06-30 at 12 21 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages closed/no-milestone feature/private-browsing priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

4 participants