Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to authenticate or use Google Keep extension in Brave #3650

Closed
Brave-Matt opened this issue Mar 10, 2019 · 60 comments · Fixed by brave/brave-core#5616
Closed

Unable to authenticate or use Google Keep extension in Brave #3650

Brave-Matt opened this issue Mar 10, 2019 · 60 comments · Fixed by brave/brave-core#5616
Assignees
Labels
feature/extensions google OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@Brave-Matt
Copy link

Brave-Matt commented Mar 10, 2019

Test Plan

Specified here: brave/brave-core#5616

Description

Google Keep extension installs but doesn't allow users to login to their google account in order to use it. Sign in button on extension panel is unresponsive - logging into Keep via G Keep website also has no effect.
image

Steps to Reproduce

  1. Install Google Keep extension
  2. Visit any website
  3. Click Sign in to use extension

Actual result:

Sign-in button is unresponsive.

Expected result:

Successfully authenticatate into google account in Keep extension.

Reproduces how often:

Always

Brave version (brave://version info)

Version 0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? Yes

Additional Information

User Reports:
https://community.brave.com/t/google-keep-application-cannot-sign-in/34972/14?preview_theme_id=24

@dinoboy197
Copy link

dinoboy197 commented Mar 15, 2019

I have the same issue. I'm using Brave: 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit) on Linux.

I use Keep all day, so having it be disabled is an unfortunate impediment to me being able to use the Brave browser exclusively.

@rebron
Copy link
Collaborator

rebron commented Mar 15, 2019

Might be fixed with the social networking landing in 64.x. Let's test this out again when that fix lands.

@rebron rebron added regression priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 15, 2019
@dinoboy197
Copy link

Thanks @rebron ! Will watch this issue for updates.

@Brave-Matt
Copy link
Author

+1 from Community:
https://community.brave.com/t/unable-to-sign-in-to-google-keep-extension/48661/4

@theNailz
Copy link

(Still) broken on Version 0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit).

@tayfurunal
Copy link

tayfurunal commented Jun 10, 2019

still broken on Version 0.65.118 Chromium: 75.0.3770.80 (Official Build) (64-bit)

@kwroebuck
Copy link

still broken on Version 0.65.121 Chromium: 75.0.3770.100 (Official Build) (64-bit)

@Brave-Matt
Copy link
Author

Another +1 from Community:
https://community.brave.com/t/unable-to-sign-in-to-google-keep-extension/48661/5?u=mattches

@coleberhorst
Copy link

still broken on Version 0.66.100 Chromium: 75.0.3770.142 (Official Build) (64-bit)

@slabo
Copy link

slabo commented Jul 28, 2019

still same issue Version 0.65.121 Chromium: 75.0.3770.100 (Official Build) (64-bit), on MX Linux, Linux mexer 4.19.0-1-amd64 #1 SMP Debian 4.19.5-2~mx17+1 (2018-12-12) x86_64 GNU/Linux

@Coriakin
Copy link

Coriakin commented Aug 4, 2019

+1; still an issue.
OS: macOS 10.14.1 (Mojave)
Brave: Version 0.67.123 Chromium: 76.0.3809.87 (Official Build) (64-bit)

This saddens me greatly :(

@Dunnomix
Copy link

+1; still an issue.
OS:Debian 10 (Buster)
Brave: Version 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)

I was just getting the hinge of google keep and wanted to have it on the desktop.

I{ll find something for:expressionless: KDE.

@Brave-Matt
Copy link
Author

+1 reddit
https://www.reddit.com/r/brave_browser/comments/d9o94b/cant_log_into_extensions_with_google_acct_oauth/

@Brave-Matt
Copy link
Author

+1 from Commiunity:
https://community.brave.com/t/google-keep-application-cannot-sign-in/34972/17?u=mattches

@brimwats1
Copy link

+1 from me -- windows 10

@ansaris
Copy link

ansaris commented Oct 20, 2019

+1
It's not specific to Google Keep, it happens when using Google Sign-in oauth on any 3rd party site.

Fix for me: Enabling all cookies, then clearing all history/cache/cookies. Attempt to log in again.
I had already disabled shields on both the 3rd party site and the Google signin popup window.
Then I changed it back to disabling only cross-site cookies. Still working until the next time I need to login.
Using Version 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit) on Windows 10.

@ansaris
Copy link

ansaris commented Oct 21, 2019

Please merge with #6408 Login with Google OAuth Not Working

@bsclifton
Copy link
Member

cc: @jumde who is looking at the OAuth issue...

@jumde jumde self-assigned this Oct 22, 2019
@jumde
Copy link
Contributor

jumde commented Oct 22, 2019

assigned it to myself.

@dlorde
Copy link

dlorde commented Dec 9, 2019

Any progress on this?

@juanjosezg
Copy link

They only ignore this issue

@rebron rebron added google webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Jan 9, 2020
@LaurenWags
Copy link
Member

@jumde should this one have QA/Yes or QA/No label?

@jumde jumde added the QA/Yes label Aug 27, 2020
@jumde
Copy link
Contributor

jumde commented Aug 27, 2020

@LaurenWags - Updated the label and the test plan.

@LaurenWags
Copy link
Member

thank you @jumde 😄

@foodfan
Copy link

foodfan commented Aug 28, 2020

I'm having problems since this change. I was logged out of all google accounts. When I logged in to gmail and google apps accounts, everything worked fine. But when I tried logging into my university alumni account, which has separate authentication, I was properly redirected, logged in, did 2FA, but when redirected to Google, was asked to "reconfirm it was me", I clicked the button but it said there was an error. Also, google drive sync crashed and logged me out. What to do?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2020

Verification passed on

Brave | 1.14.66 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.14.81 Chromium: 85.0.4183.102 (Official Build) (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)
  • extensive QAing done also completed via [Desktop] google account info showing in profile manager #11444 (comment)
  • ensured that clicking on Sign In via Google Keep doesn't freeze/hang Brave when Allow Google login for extensions is disabled under brave://settings/extensions
  • ensured that clicking on Sign in via Google Keep opens a new tab that lets you login into Google once Allow Google under brave://settings/extensions has been enabled
  • ensured that you can sign into Google Keep once Allow Google login for extensions has been enabled under brave://settings/extensions
Google Login Enabled
Screen Shot 2020-09-14 at 2 44 47 PM
Google Login Disabled
Screen Shot 2020-09-14 at 2 44 16 PM

Verification passed on

Brave 1.14.81 Chromium: 85.0.4183.102 (Official Build) (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS

Verified in #11444

@jumde
Copy link
Contributor

jumde commented Aug 28, 2020

Thanks for the feedback @foodfan - I'm investigating the issue that you're running into. Will post updates here.

@bsclifton
Copy link
Member

@foodfan (love the name) - just to confirm, you're on Beta or Nightly? This code hasn't reached Release (1.13) channel yet

@foodfan
Copy link

foodfan commented Aug 28, 2020

@foodfan (love the name) - just to confirm, you're on Beta or Nightly? This code hasn't reached Release (1.13) channel yet

Haha, thanks.

I am on the Beta channel. Version 1.14.65 Chromium: 85.0.4183.83 (Official Build) beta (64-bit)

Hope that helps

@foodfan
Copy link

foodfan commented Aug 31, 2020

Seems like this was a cookie problem. To fix, I deleted all "google" cookies and re-logged in to my primary (gmail), google apps, and finally alumni account. Note: I did not log out of the extension (not sure if it's a separate cookie or not) but it continued working. I was also able to authenticate Google Backup & Sync. Everything seems to be working now. Thanks for the responsiveness to this and for making Keep work.

@jumde
Copy link
Contributor

jumde commented Aug 31, 2020

Thanks for the update @foodfan , if you run into any additional issues let us know. 👍

@dsg38
Copy link

dsg38 commented Sep 16, 2020

In case any one else is stuck at the same point - emphasising part of @GeetaSarvadnya post - it's essential that that Allow Google login for extensions has been enabled in settings. As this was blocking it for me and clicking 'sign in' on the keep extension did not prompt this setting request

@jtnydv
Copy link

jtnydv commented Feb 8, 2021

Still facing this issue and none of the suggested solutions works.

When I enable Allow Google login for extensions I keep getting the Google login screen and the extension doesn't work.
Can anyone suggest any workaround for this?

@jumde
Copy link
Contributor

jumde commented Feb 8, 2021

Thanks for the report @jtnydv - I verified that this is a regression. Tracking the issue here: #14041 - Will try to resolve this soon.

@JoseJuanSE
Copy link

I allowed google login for extensions, now when I push sign in button, I get redirected to google login, after I logged, I'm again in the same place. Google keep is still asking me for log in.

@nickgroverx
Copy link

I did these two and it worked for me:

  1. Allow google login for extensions, and
  2. Allow all cookies.

@matthughes404
Copy link

matthughes404 commented Apr 27, 2021

After updating to the latest Brave version (and enabling the 'Allow Google login for extensions' setting), the Google Keep extension is working properly for me.

Version 1.23.73 Chromium: 90.0.4430.85 (Official Build) (64-bit)

@KharmaScribbles
Copy link

Best fix and best extension for Google Loyalists is just use https://apps.jeurissen.co/black-menu-for-google extension, when I installed Brave and asked it to import my extensions from Chrome, all my extensions worked from the get-go and all google apps work within the black-menu-for-google extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/extensions google OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

Successfully merging a pull request may close this issue.