Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow hiding of BR icon when user has never enabled it #3565

Closed
rebron opened this issue Mar 4, 2019 · 4 comments
Closed

allow hiding of BR icon when user has never enabled it #3565

rebron opened this issue Mar 4, 2019 · 4 comments

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 4, 2019

Description

A user should be able to hide Brave Rewards icon when they've never joined/enabled Brave Rewards.

Steps to Reproduce

  1. New profile.
  2. Don't join, don't enable Brave Rewards.
  3. Go to Settings and select Hide Brave Rewards button.
  4. Notice BR button is still visible.

Actual result:

hide icon

Expected result:

Brave Rewards button is hidden.

@rebron
Copy link
Collaborator Author

rebron commented Mar 4, 2019

Follow up to: #2975

@kjozwiak kjozwiak added the QA/Yes label Mar 5, 2019
@rebron
Copy link
Collaborator Author

rebron commented Mar 5, 2019

@mkarolin mentioned this might me macOS only, need to verify on WIn/Linux.

@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2019

I can't seem to reproduce this on the following platforms:

  • Win 10 x64 VM (clean profile/BR not enabled) - Couldn't reproduce
  • macOS 10.14.3 x64 (clean profile/BR not enabled) - Couldn't reproduce
  • Mint 19.1 x64 VM (clean profile/BR not enabled) - Couldn't reproduce

Used the following build for the above checks:

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}

Example of the switch being toggled on a profile that never had BR enabled:

rewardsbutton

@rebron @mkarolin which version did the happen on? Possibly regressed somewhere in 0.62.x or 0.63.x? Seems to be working fine under 0.61.x. Is there better STR? Possibly an edge case?

@rebron
Copy link
Collaborator Author

rebron commented Mar 5, 2019

@anthonypkeane any more details on steps to reproduce?

I'm going to go ahead and close, marking invalid. Can't reproduce this either on 61.43 clean macOS build 10.14.2

@rebron rebron closed this as completed Mar 5, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Mar 15, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 8, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants