Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from C120 -> C121 on Win x64 via 1.63.x - Nightly (Checking C121) #35281

Closed
36 tasks done
kjozwiak opened this issue Jan 11, 2024 · 2 comments
Closed
36 tasks done

Upgrade from C120 -> C121 on Win x64 via 1.63.x - Nightly (Checking C121) #35281

kjozwiak opened this issue Jan 11, 2024 · 2 comments
Assignees
@MadhaviSeelam
Labels
OS/Desktop OS/Windows QA Pass-Win64 QA Pass-Win86 QA/Yes release-notes/exclude tests
Milestone
1.63.x - Release

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Jan 11, 2024 •
edited by MadhaviSeelam
Loading

As per process, QA runs through the following cases to ensure that the major chromium bump that's about to get merged into master doesn't regress the Nightly channel. Once the major chromium bump is merged into master, QA will run through a full manual pass on Windows & Android.

Startup & Components

  • Verify that Brave is only contacting *.brave.com endpoints on first launch using either Charles Proxy, Fiddler, Wireshark or LittleSnitch (or a similar application)
    • Verify that opening a NTP doesn't trigger any outbound connections related to widgets without user interaction
  • Remove the following component folders and ensure that they're being re-downloaded after restarting the browser:
    • afalakplffnnnlkncjhbmahjfjhmlkal: AutoplayWhitelist.dat, ExtensionWhitelist.dat, ReferrerWhitelist.json and Greaselion.json
    • CertificateRevocation
    • gccbbckogglekeggclmmekihdgdpdgoe: (Sponsored New Tab Images)
    • gkboaolpopklhgplhaaiboijnklogmbc: Brave Ad Block List Catalog
    • iodkpdagapdfkphljnddpjlldadblomo: Brave Ad Block Updater
    • mfddibmblmbccpadfndgakiopmmhebop: Brave Ad Block List Catalog
    • oofiananboodjbbmdelgdommihjbkfag: HTTPSE
    • Safe Browsing
  • Restart the browser, load brave://components, wait for 8 mins and verify that no component shows any errors

Note: Always double check brave://components to make sure there's no errors/missing version numbers

Upgrade

  • Make sure that data from the last version appears in the new version OK
  • Ensure that brave://version lists the expected Brave & Chromium versions
  • With data from the last version, verify that:
    • Bookmarks on the bookmark toolbar and bookmark folders can be opened
    • Cookies are preserved
    • Installed extensions are retained and work correctly
    • Opened tabs can be reloaded
    • Stored passwords are preserved
    • Sync chain created in previous version is retained
    • Social media-blocking buttons changes are retained
    • Custom filters under brave://settings/shields/filters are retained
    • Custom lists under brave://settings/shields/filters are retained
    • Rewards
      • BAT balance is retained
      • Auto-contribute list is retained
      • Both Tips and Monthly Contributions are retained
      • Panel transactions list is retained
      • Changes to rewards settings are retained
      • Ensure that Auto Contribute is not being enabled when upgrading to a new version if AC was disabled
    • Ads
      • Both Estimated pending rewards & Ad notifications received this month are retained
      • Changes to ads settings are retained
      • Ensure that ads are not being enabled when upgrading to a new version if they were disabled
      • Ensure that ads are not disabled when upgrading to a new version if they were enabled
@kjozwiak kjozwiak added this to the 1.63.x - Nightly milestone Jan 11, 2024
@MadhaviSeelam MadhaviSeelam self-assigned this Jan 11, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 12, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.63.110 Chromium: 121.0.6167.57 (Official Build) nightly (64-bit)
-- | --
Revision | f7a7c2ee42626f5a1310c9bd6789d0438e78ca6e
OS | Windows 11 Version 22H2 (Build 22621.3007)
C120 --> C121 on-demand upgrade check - PASSED
  • installed 1.63.113 Chromium: 120.0.6099.217 and closed Brave
  • created HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url and set url as the following:
    • https://updates.brave.com/service/update2
  • set HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\ClientState\{C6CB981E-DB30-4876-8639-109F8933582C}\ap as nightly (usually cr-bump-update-tests-x64 is used but this time around nightly was used)
  • realunched Brave and visited brave://settings/help and ensured that new update was being pulled/downloaded
  • ensured that clicking Relaunch restarted the browser without any issues
  • ensured Brave was updated to 1.63.110 Chromium: 121.0.6167.57 without any issues and you can restart the browser
Example Example Example Example Example
image image image image image
C120 --> C121 background upgrade check - PASSED
  • installed 1.63.113 Chromium: 120.0.6099.217 and closed Brave
  • created HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url and set url as the following:
    • https://updates.brave.com/service/update2
  • set HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\ClientState\{C6CB981E-DB30-4876-8639-109F8933582C}\ap as nightly (usually cr-bump-update-tests-x64 is used but this time around nightly was used)
  • started BraveSoftwareUpdateTaskMachineUA{92BFBA70-A7D5-434D-9909-FE8301164450} via Task Scheduler
  • waited ~30min or so before launching Brave and ensured it was updated to 1.63.110 Chromium: 121.0.6167.57- FAILED
  • restarted Brave several times and ensured that there's no issues re-launching Brave once it was updated via the background
Example Example Example Example
image image image !image
C121 --> C121 on-demand upgrade check - PASSED
  • installed 1.63.110 Chromium: 121.0.6167.57 via BraveBrowserStandaloneNightlySetup_121_1_63_110.exe and closed Brave
  • created HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url and set url as the following:
    • https://updates.brave.com/service/update2
  • set HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\ClientState\{C6CB981E-DB30-4876-8639-109F8933582C}\ap as nightly (usually cr-bump-update-tests-x64 is used but this time around nightly was used)
  • relaunched Brave and visited brave://settings/help and ensured that new update was being pulled/downloaded
  • ensured that clicking Relaunch restarted the browser without any issues
  • ensured Brave was updated to 1.63.113 Chromium: 121.0.6167.57 without any issues and you can restart the browser
Example Example Example Example Example
image image image image image
C121 --> C121 background upgrade check - PASSED
  • installed 1.63.110 Chromium: 121.0.6167.57 via BraveBrowserStandaloneNightlySetup32_121_1_63_110.exe and closed Brave
  • created HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\UpdateDev\url and set url as the following:
    • https://updates.brave.com/service/update2
  • set Computer\HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\Update\ClientState\{C6CB981E-DB30-4876-8639-109F8933582C}\ap as nightly (usually cr-bump-update-tests-x86 is used but this time around nightly was used)
  • started BraveSoftwareUpdateTaskMachineUA{92BFBA70-A7D5-434D-9909-FE8301164450} via Task Scheduler
  • waited ~30min or so before launching Brave and ensured it was updated to 1.63.113 Chromium: 121.0.6167.57
  • restarted Brave several times and ensured that there's no issues re-launching Brave once it was updated via the `background
Example Example Example Example Example
image image image image

@kjozwiak
Copy link
Member Author

kjozwiak commented Jan 12, 2024 •
edited
Loading

Verification PASSED on Win 10 x86 using the following build(s):

Brave | 1.63.113 Chromium: 121.0.6167.57 (Official Build) nightly (32-bit)
-- | --
Revision | baf10610d0ea5f609e5bf2e656f91c2e58568fd9
OS | Windows 10 Version 22H2 (Build 19045.3803)
C120 --> C121 on-demand upgrade check - PASSED
  • installed 1.63.101 Chromium: 120.0.6099.199 and closed Brave
  • created HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\UpdateDev\url and set url as the following:
    • https://updates.brave.com/service/update2
  • set Computer\HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\Update\ClientState\{C6CB981E-DB30-4876-8639-109F8933582C}\ap as nightly (usually cr-bump-update-tests-x86 is used but this time around nightly was used)
  • realunched Brave and visited brave://settings/help and ensured that new update was being pulled/downloaded
  • ensured that clicking Relaunch restarted the browser without any issues
  • ensured Brave was updated to 1.63.113 Chromium: 121.0.6167.57 without any issues and you can restart the browser
Example Example Example Example
image image image image
C121 --> C121 on-demand upgrade check - PASSED
  • installed 1.63.110 Chromium: 121.0.6167.57 via BraveBrowserStandaloneNightlySetup32_121_1_63_110.exe and closed Brave
  • created HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\UpdateDev\url and set url as the following:
    • https://updates.brave.com/service/update2
  • set Computer\HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\Update\ClientState\{C6CB981E-DB30-4876-8639-109F8933582C}\ap as nightly (usually cr-bump-update-tests-x86 is used but this time around nightly was used)
  • realunched Brave and visited brave://settings/help and ensured that new update was being pulled/downloaded
  • ensured that clicking Relaunch restarted the browser without any issues
  • ensured Brave was updated to 1.63.113 Chromium: 121.0.6167.57 without any issues and you can restart the browser
Example Example Example Example
image image image image
C120 --> C121 background upgrade check - PASSED
  • installed 1.63.101 Chromium: 120.0.6099.199 and closed Brave
  • created HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\UpdateDev\url and set url as the following:
    • https://updates.brave.com/service/update2
  • set Computer\HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\Update\ClientState\{C6CB981E-DB30-4876-8639-109F8933582C}\ap as nightly (usually cr-bump-update-tests-x86 is used but this time around nightly was used)
  • started BraveSoftwareUpdateTaskMachineUA{B3C81AC2-A16A-4EEB-BB45-02A4E9209FCF} via Task Scheduler
  • waited ~30min or so before launching Brave and ensured it was updated to 1.63.113 Chromium: 121.0.6167.57
  • restarted Brave several times and ensured that there's no issues re-launching Brave once it was updated via the background
Example Example Example Example
image image image image
C121 --> C121 background upgrade check - PASSED
  • installed 1.63.110 Chromium: 121.0.6167.57 via BraveBrowserStandaloneNightlySetup32_121_1_63_110.exe and closed Brave
  • created HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\UpdateDev\url and set url as the following:
    • https://updates.brave.com/service/update2
  • set Computer\HKEY_LOCAL_MACHINE\SOFTWARE\BraveSoftware\Update\ClientState\{C6CB981E-DB30-4876-8639-109F8933582C}\ap as nightly (usually cr-bump-update-tests-x86 is used but this time around nightly was used)
  • started BraveSoftwareUpdateTaskMachineUA{761D123A-3521-4F8F-8DBC-D0F630D2016A} via Task Scheduler
  • waited ~30min or so before launching Brave and ensured it was updated to 1.63.113 Chromium: 121.0.6167.57
  • restarted Brave several times and ensured that there's no issues re-launching Brave once it was updated via the `background
Example Example Example Example
image image image image

@MadhaviSeelam MadhaviSeelam mentioned this issue Jan 12, 2024
Closed
@brave brave deleted a comment from MadhaviSeelam Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadhaviSeelam MadhaviSeelam

Labels
OS/Desktop OS/Windows QA Pass-Win64 QA Pass-Win86 QA/Yes release-notes/exclude tests
Projects
None yet
Milestone
1.63.x - Release
Development

No branches or pull requests
2 participants
@kjozwiak @MadhaviSeelam