Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI to notify users that social blocking was done #3490

Closed
bbondy opened this issue Feb 25, 2019 · 0 comments
Closed

Add UI to notify users that social blocking was done #3490

bbondy opened this issue Feb 25, 2019 · 0 comments
Labels
closed/wontfix design A design change, especially one which needs input from the design team priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@bbondy
Copy link
Member

bbondy commented Feb 25, 2019

This is Step 3 of the plan outlined in this issue:
#3475
In the section "Summary of the plan"

Step 2 of this plan was here:
#3489

Step 3: Add a UI which allows us to block by default but inform the user in case they want to enable the functionality.

To do those options I think a good way will be via an extension to AdBlockPlus filter syntax for tagging filter rules:
$tags=embedded-tweets would tag a rule as being related to the embedded tweets option.
When we do matching, if the option for embedded tweets is off, we'd ignore any filters with the tag embedded-tweets. Clients would specify matching options to use, and AdBlockClient::matches would ignore the things that are specified.

@bbondy bbondy self-assigned this Feb 25, 2019
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 25, 2019
@rebron rebron added the design A design change, especially one which needs input from the design team label Mar 4, 2019
@bbondy bbondy closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix design A design change, especially one which needs input from the design team priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
Status: Completed
Development

No branches or pull requests

3 participants