Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad Ads info to settings box #3468

Closed
ryanml opened this issue Feb 23, 2019 · 5 comments · Fixed by brave/brave-core#1768
Closed

Ad Ads info to settings box #3468

ryanml opened this issue Feb 23, 2019 · 5 comments · Fixed by brave/brave-core#1768

Comments

@ryanml
Copy link
Contributor

ryanml commented Feb 23, 2019

Tracker: #3141

We are only going to be showing the estimated earnings and the notifications received data points. The monthly payment date is hard coded for now per @jsecretan

46828601-6af02180-cd50-11e8-98dc-1b709a4a2460

@mandar-brave
Copy link

mandar-brave commented Feb 25, 2019

@jsecretan and @ryanml to simplify -

a) all stats including estimated earnings reset as month changes (local TZ midnight reset)
b) payment days stays static - i think it is the 8th (in sync with the pub date). however if a reward is presented to user, say on the 6th, the next payment day will move to the next date (so a little bit more dependent on where user can claim reward)

@mandar-brave
Copy link

mandar-brave commented Feb 26, 2019

On review - the assumption for the original requirements was that we ask user to claim rewards as the month changes; here are the new requirements ---- when the month changes.

a) keep the estimated rewards to keep collecting
b) only when the rewards claim is made and rewards are captured, the estimated rewards resets with the next payment

@NejcZdovc
Copy link
Contributor

@tmancey @ryanml please check if this is implemented

@jsecretan
Copy link

Let's hold off on these changes for right now, get this merged in and make another story after some additional discussion.

@LaurenWags
Copy link
Member

LaurenWags commented Apr 17, 2019

Verified passed with

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

Used test plan and screenshot from brave/brave-core#1768

image

image

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment