Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertical tabs] Frame button mis-positioned on linux with title bar #34201

Closed
rillian opened this issue Nov 8, 2023 · 4 comments · Fixed by brave/brave-core#20937
Closed
Assignees

Comments

@rillian
Copy link

rillian commented Nov 8, 2023

Description

Follow-up to #33928 which showed a similar misalignment when the title bar was hidden, as it is by default on the more popular desktop environments.

Steps to Reproduce

  1. Open settings (brave://settings in the address bar)
  2. Search for 'tab'
  3. Click to enable 'Use vertical tabs'
  4. Click to select 'Show title bar'

Actual result:

Close button and other window decorations are drawn half on the toolbar, half on the title bar, neither aligned with the other toolbar buttons nor in the expected place in the title bar.

image

Expected result:

Close button (and min/max buttons, if the desktop theme includes them) should be aligned with the other toolbar buttons as they are when the title bar is not shown

Reproduces how often:

Always. Tried both Fedora 39 (gnome-shell) and Pop OS 22.04.

Brave version (brave://version info)

1.62.32 Chromium: 119.0.6045.105 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@ltrook21
Copy link

ltrook21 commented Nov 8, 2023

I too have this issue. Pop_OS 22.04 LTS - Razer Blade 15 2022 Release Notes v1.60.110 (Nov 2, 2023)
image

@sangwoo108 sangwoo108 self-assigned this Nov 9, 2023
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 10, 2023
@biohazard2117
Copy link

biohazard2117 commented Nov 11, 2023

Having the same issue even without toggling on the "show title bar".

Ubuntu 23.10
Version 1.60.114 Chromium: 119.0.6045.124 (Official Build) (64-bit)
image

@kjozwiak
Copy link
Member

The above requires 1.60.120 or higher for 1.60.x verification 👍

@btlechowski
Copy link

Verified with

Brave 1.60.124 Chromium: 119.0.6045.163 (Official Build) (64-bit)
Revision 803c85554783c998a840f4b211c94236409a9928
OS Linux

Verified test plan for the description

Reproduced the issue:
image

Verified the issue:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants