Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable #power-bookmarks-side-panel #33886

Closed
rebron opened this issue Oct 24, 2023 · 2 comments · Fixed by brave/brave-core#20664
Closed

Disable #power-bookmarks-side-panel #33886

rebron opened this issue Oct 24, 2023 · 2 comments · Fixed by brave/brave-core#20664
Assignees
Labels
feature/bookmarks feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 24, 2023

Description

Disable #power-bookmarks-side-panel with Chromium 119 update for now. This flag is still available but flag is no longer visible via brave://flags

Related flag is currently disabled: brave://flags/#power-bookmark-backend and also needs to be evaluated if this needs to be enabled as part of power-bookmarks-side-panel in the future.

We do want to switch to the power bookmarks side panel but need to understand dependency with the related flag and other feedback and improvements on the Chromium side as it's a more complex UX (power bookmarks UX was not adopted by Edge).

Actual result:

Screenshot 2023-10-24 at 12 40 50 PM
Brave 1.61.48 Chromium: 119.0.6045.33 (Official Build) nightly (arm64)
Revision 50bf5d1
OS macOS Version 14.1 (Build 23B73)
JavaScript V8 11.9.169.4
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36

Expected result:

Screenshot 2023-10-24 at 12 41 44 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? yes with CR 119

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? yes. Their new bookmarks side panel.

Miscellaneous Information:

@kjozwiak
Copy link
Member

kjozwiak commented Oct 26, 2023

The above requires 1.60.105 or higher for 1.60.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 27, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 27, 2023

Verification PASSED on

Brave | 1.60.105 Chromium: 119.0.6045.59 (Official Build) (64-bit)
-- | --
Revision | a39727aa81373a09a915478fcb35826242c37335
OS | Windows 10 Version 22H2 (Build 19045.3570)

Before disabling #power-bookmarks-side-panel 1.61.50

Example Example Example
image image image

After disabling #power-bookmarks-side-panel 1.60.105

Example Example Example
image image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/bookmarks feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants