Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - iOS should be using inheritance to override Chromium Main #33746

Closed
Brandon-T opened this issue Oct 19, 2023 · 0 comments · Fixed by brave/brave-core#20598
Closed

[iOS] - iOS should be using inheritance to override Chromium Main #33746

Brandon-T opened this issue Oct 19, 2023 · 0 comments · Fixed by brave/brave-core#20598
Assignees
@Brandon-T
Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Milestone
1.60.x - Release

Comments

@Brandon-T
Copy link

Description

  • Brave-Core-iOS is overriding the entire ApplicationContextImpl when it really only needs to override 3 functions.
  • Brave-Core-iOS is duplicating a lot of code for BraveWebMain and BraveWebClient but it can use inheritance and just override the functions it needs to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brandon-T Brandon-T

Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging a pull request may close this issue.

Fix #33746: Cleanup Brave-Core iOS chromium_src overrides & initialization code brave/brave-core
3 participants
@Brandon-T @kjozwiak @brave-builds