Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto scroll can be distracting #32970

Closed
bbondy opened this issue Sep 13, 2023 · 5 comments · Fixed by brave/brave-core#21235
Closed

Auto scroll can be distracting #32970

bbondy opened this issue Sep 13, 2023 · 5 comments · Fixed by brave/brave-core#21235
Assignees
@nullhook
Labels
browser-ai feature/user-interface All UI related OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Sep 13, 2023

We need to stop auto-scroll as content floods in because you are already reading the top of the content but then can’t as it scrolls out of sight.
I do think we should scroll the top of the answer into view
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 13, 2023
@bbondy bbondy moved this to Todo in Browser AI Sep 13, 2023
@bbondy bbondy moved this from Todo to Important / Polish in Browser AI Oct 26, 2023
@Brave-Matt
Copy link

Agreed — made a similar comment here: https://bravesoftware.slack.com/archives/C04KPE0BUDU/p1698346929744069

I think we should make it so that if you scroll up at least once, it will stop automatically scrolling down with the response.

@bbondy
Copy link
Member Author

bbondy commented Nov 14, 2023

I think the solution here is to auto scroll only if the scroll position is at the bottom.

@nullhook nullhook mentioned this issue Dec 5, 2023
Merged
25 tasks
@nullhook nullhook moved this from Important / Polish to In Progress in Browser AI Dec 5, 2023
@nullhook nullhook self-assigned this Dec 13, 2023
@nullhook nullhook moved this from In Progress to In Review in Browser AI Dec 13, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Jan 17, 2024
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Jan 17, 2024
@petemill petemill moved this from Done to Needs Uplift in Browser AI Jan 17, 2024
@nullhook nullhook mentioned this issue Jan 18, 2024
Merged
@kjozwiak kjozwiak moved this from Needs Uplift to Done in Browser AI Jan 20, 2024
@kjozwiak
Copy link
Member

Adding QA/Blocked for now as the above was merged into cr121-1.62.x via brave/brave-core#21593. Once C121 is merged into 1.62.x via brave/brave-core#21593, we'll unblock the above and mention the needed 1.62.x version for verification 👍

@kjozwiak kjozwiak mentioned this issue Jan 20, 2024
Merged
24 tasks
@kjozwiak
Copy link
Member

The above requires 1.62.148 or higher for 1.62.x verification 👍

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 22, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (x86_64)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.62.149
  2. launched Brave using --env-leo=staging --env-ai-chat.bsg=dev --env-ai-chat-premium.bsg=dev --enable-logging=stderr --v=2
  3. loaded https://constitutioncenter.org/the-constitution/full-text
  4. clicked on Summarize this page
  5. waited for auto-scrolling to start
  6. swiped up and waited
  7. scrolled down

stop-autoscroll

@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 22, 2024
@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
browser-ai feature/user-interface All UI related OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Browser AI
Status: Done
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

aichat: scroll is interruptable brave/brave-core
7 participants
@stephendonner @bbondy @kjozwiak @Brave-Matt @rebron @nullhook @brave-builds