Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedreader: System theme checkmark renders badly on Linux #32947

Closed
rillian opened this issue Sep 12, 2023 · 3 comments · Fixed by brave/brave-core#20170
Closed

Speedreader: System theme checkmark renders badly on Linux #32947

rillian opened this issue Sep 12, 2023 · 3 comments · Fixed by brave/brave-core#20170
Assignees
Labels
design A design change, especially one which needs input from the design team feature/speedreader misc/icons OS/Desktop OS/Linux priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/include

Comments

@rillian
Copy link

rillian commented Sep 12, 2023

Description

When selecting "System Theme" on the new speedreader control header, the checkmark renders misaligned somehow, looking janky so it's hard to tell what's going on.

Steps to Reproduce

  1. Visit page with speed reader enabled
  2. Click "appearance" button
  3. Click "sytem theme" black-and-white circle

Actual result:

Blue circle with a checkmark is drawn but comes out half-black/half-white:
image

I think maybe the logic that makes the checkmark dark on the light buttons and light on the dark button is confused by the alternating light-dark pattern of the system theme button?

Expected result:

Should overlay cleanly like on the other theme selectors:
image

Reproduces how often:

Always

Brave version (brave://version info)

1.58.101 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel?
@rebron rebron added misc/icons design A design change, especially one which needs input from the design team priority/P4 Planned work. We expect to get to it "soon". release-notes/include QA/Yes labels Sep 12, 2023
@aguscruiz
Copy link

@boocmp we could solve this by adding a small white circle behind the check icon, so it doesn't become transparent with the background

@rillian
Copy link
Author

rillian commented Oct 24, 2023

Verification PASSED on Fedora Linux 38 x86_64 using the following build(s):

Brave | 1.60.96 Chromium: 118.0.5993.88 (Official Build) beta (64-bit) 
-- | --
Revision | b4c059ad1d32d6e0cd1466123f03ccb97b3cf858
OS | Linux

image
image

@kjozwiak
Copy link
Member

Awesome, thanks @rillian 🎉 Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/speedreader misc/icons OS/Desktop OS/Linux priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants