Speedreader: System theme checkmark renders badly on Linux #32947
Labels
design
A design change, especially one which needs input from the design team
feature/speedreader
misc/icons
OS/Desktop
OS/Linux
priority/P4
Planned work. We expect to get to it "soon".
QA Pass-Linux
QA/Yes
release-notes/include
Milestone
Description
When selecting "System Theme" on the new speedreader control header, the checkmark renders misaligned somehow, looking janky so it's hard to tell what's going on.
Steps to Reproduce
Actual result:
Blue circle with a checkmark is drawn but comes out half-black/half-white:
![image](https://private-user-images.githubusercontent.com/225102/267452492-0d1b9bfc-7b2e-4dad-82b5-e4b92ee4171f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzY2NjgsIm5iZiI6MTczOTEzNjM2OCwicGF0aCI6Ii8yMjUxMDIvMjY3NDUyNDkyLTBkMWI5YmZjLTdiMmUtNGRhZC04MmI1LWU0YjkyZWU0MTcxZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQyMTI2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kNzJhZDJmZDk4MTNkZTZjOTUzMmZhYTNmMmVkZTE4ZGI3NWRhYThjNGJjNjYyNjNjZTQ1NWUzNjk4NzlkNWJhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.CXXHa8sw6Z9y_UNNM68J9vb6XkpoNdXs9jNF2kiMap0)
I think maybe the logic that makes the checkmark dark on the light buttons and light on the dark button is confused by the alternating light-dark pattern of the system theme button?
Expected result:
Should overlay cleanly like on the other theme selectors:
![image](https://private-user-images.githubusercontent.com/225102/267452646-4b117656-574c-4771-9eab-753cbcc49132.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzY2NjgsIm5iZiI6MTczOTEzNjM2OCwicGF0aCI6Ii8yMjUxMDIvMjY3NDUyNjQ2LTRiMTE3NjU2LTU3NGMtNDc3MS05ZWFiLTc1M2NiY2M0OTEzMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOVQyMTI2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hMWRiODc0NjRhZDE4ODhlNjVmM2I1NzJkYzc1YjYxYjM1NDJmMjMxNTkwMWJhNzM3YzNlNGZlNWMzMDY0NmZmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.8OJTCcEqVBvW7ZpoKCP1F6PZhA-QGx6FhwYREQ_mE3s)
Reproduces how often:
Always
Brave version (brave://version info)
1.58.101 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Version/Channel Information:
The text was updated successfully, but these errors were encountered: