Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent - missing percent sign and improve file size labelling #3285

Closed
leobel96 opened this issue Feb 8, 2019 · 1 comment · Fixed by brave/brave-core#2216
Closed
Labels
design A design change, especially one which needs input from the design team feature/webtorrent Label for webtorrent related issues priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@leobel96
Copy link

leobel96 commented Feb 8, 2019

Description

Missing percentage and measuring unit for file size in WebTorrent

Test plan / Steps to Reproduce

  1. Visit https://webtorrent.io/torrents/sintel.torrent
  2. Click Start torrent

Actual result:

inkedannotazione 2019-02-08 230030_li

Expected result:

inkedannotazione 2019-02-08 230030_li

Reproduces how often:

Easily

Brave version (brave://version info):

0.59.35 Chromium: 72.0.3626.81 (Build ufficiale) (a 64 bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

Also it would be good the presence of upload speed

@leobel96 leobel96 changed the title Percentage missing in WebTorrent WebTorrent imperfections Feb 8, 2019
@srirambv srirambv added design A design change, especially one which needs input from the design team priority/P5 Not scheduled. Don't anticipate work on this any time soon. feature/webtorrent Label for webtorrent related issues labels Feb 9, 2019
@bsclifton bsclifton added this to the 0.69.x - Nightly milestone Jul 18, 2019
bsclifton added a commit to brave/brave-core that referenced this issue Jul 18, 2019
bsclifton pushed a commit to brave/brave-core that referenced this issue Jul 18, 2019
Resolves brave/brave-browser#3285

Only match on root README

test
@srirambv
Copy link
Contributor

srirambv commented Aug 29, 2019

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

image

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Screen Shot 2019-09-03 at 2 57 24 PM

@rebron rebron changed the title WebTorrent imperfections WebTorrent - missing percent sign and file size labelling Oct 2, 2019
@rebron rebron changed the title WebTorrent - missing percent sign and file size labelling WebTorrent - missing percent sign and improve file size labelling Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/webtorrent Label for webtorrent related issues priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants