Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Brave Rewards button in Tor/Guest Windows #3215

Closed
rebron opened this issue Feb 4, 2019 · 2 comments
Closed

Hide Brave Rewards button in Tor/Guest Windows #3215

rebron opened this issue Feb 4, 2019 · 2 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@rebron
Copy link
Collaborator

rebron commented Feb 4, 2019 •
edited
Loading

Description

Hide Brave Rewards button in Guest windows. We won't support Brave Rewards in Guest windows/Guest mode.

Hide Brave Rewards icon in Private Windows w/ Tor -- for now until we get support for Brave Rewards in Tor.

Actual result:

Notice Brave Rewards button are displayed but disabled in both Guest and Tor windows.

Expected result:

Brave Rewards button is not displayed at all in Guest and Tor windows (for now)
@rebron
Copy link
Collaborator Author

rebron commented Feb 4, 2019

cc: @tomlowenthal

@rebron rebron added this to the Dupe / Invalid / Not actionable milestone Feb 4, 2019
@rebron
Copy link
Collaborator Author

rebron commented Feb 4, 2019

#2975 (comment)
Marking as dupe of 2975.

@rebron rebron closed this as completed Feb 4, 2019
@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed feature/rewards feature/tor labels Feb 6, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @kjozwiak @rebron @mkarolin