Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign-In with Ethereum (Desktop UI) #32078

Closed
darkdh opened this issue Aug 3, 2023 · 1 comment · Fixed by brave/brave-core#19443
Closed

Sign-In with Ethereum (Desktop UI) #32078

darkdh opened this issue Aug 3, 2023 · 1 comment · Fixed by brave/brave-core#19443
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.60.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Aug 3, 2023

parent issue: #32076
@darkdh darkdh added OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/dapps labels Aug 3, 2023
@darkdh darkdh added this to Web3 Aug 3, 2023
@darkdh darkdh added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 4, 2023
@darkdh darkdh moved this to Backlog in Web3 Aug 4, 2023
@Douglashdaniel Douglashdaniel moved this from Backlog to In Progress in Web3 Aug 11, 2023
@darkdh darkdh mentioned this issue Aug 16, 2023
Merged
25 tasks
@darkdh darkdh moved this from In Progress to In Review in Web3 Sep 5, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Sep 13, 2023
@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 13, 2023
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 13, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.60.104 Chromium: 118.0.5993.117 (Official Build) (64-bit)
Revision 5dfa047eac682ad367174af6503fc21b59db5977
OS Windows 11 Version 22H2 (Build 22621.2283)
  • Verified steps from brave/brave-core#19443
  • Verified Sign-In with Ethereum UI is shown when trying to approve and sign-in on https://login.xyz
  • Verified clicking on See details on SIWE UI shows details of the message
  • Verified SIWE with resources list the resource details in the message details on https://metamask.github.io/test-dapp
  • Verified error message is shown for Wrong statement format, Domain mismatch. Account mismatch and Network mismatch when format is wrong
  • Verified no error message is shown and falls back to EIP-191 format when an incorrect format is used
32078.mp4

Verification passed on

Brave 1.60.104 Chromium: 118.0.5993.117 (Official Build) (64-bit)
Revision 5dfa047eac682ad367174af6503fc21b59db5977
OS Linux
  • Verified steps from brave/brave-core#19443
  • Verified Sign-In with Ethereum UI is shown when trying to approve and sign-in on https://login.xyz
  • Verified clicking on See details on SIWE UI shows details of the message
  • Verified SIWE with resources list the resource details in the message details on https://metamask.github.io/test-dapp
  • Verified error message is shown for Wrong statement format, Domain mismatch. Account mismatch and Network mismatch when format is wrong
  • Verified no error message is shown and falls back to EIP-191 format when an incorrect format is used
32078.mp4

Verification passed on

Brave 1.60.104 Chromium: 118.0.5993.117 (Official Build) (64-bit)
Revision 5dfa047eac682ad367174af6503fc21b59db5977
OS macOS Version 14.0 (Build 23A344)
  • Verified steps from brave/brave-core#19443
  • Verified Sign-In with Ethereum UI is shown when trying to approve and sign-in on https://login.xyz
  • Verified clicking on See details on SIWE UI shows details of the message
  • Verified SIWE with resources list the resource details in the message details on https://metamask.github.io/test-dapp
  • Verified error message is shown for Wrong statement format, Domain mismatch. Account mismatch and Network mismatch when format is wrong
  • Verified no error message is shown and falls back to EIP-191 format when an incorrect format is used
32078.mp4

@LaurenWags LaurenWags mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.60.x - Release
Development

Successfully merging a pull request may close this issue.

Sign-In with Ethereum brave/brave-core
4 participants
@darkdh @srirambv @Douglashdaniel @brave-builds