Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync chain creator does not get some bookmarks on initial sync #3182

Closed
btlechowski opened this issue Feb 1, 2019 · 3 comments · Fixed by brave/brave-core#1532
Closed

Sync chain creator does not get some bookmarks on initial sync #3182

btlechowski opened this issue Feb 1, 2019 · 3 comments · Fixed by brave/brave-core#1532

Comments

@btlechowski
Copy link

btlechowski commented Feb 1, 2019

Steps to Reproduce

bookmarks: bookmarks.zip

Note: Windows is the sync chain creator

  1. Clean install on Windows
  2. On Windows: import attached bookmarks: bookmarks_windows.html
  3. Clean install on Linux
  4. On Linux: import attached bookmarks: bookmarks_linux.html
  5. On Windows: Go to brave://sync/ and Start a new sync chain
  6. On Windows: Click Computer and copy sync code
  7. On Linux: Go to brave://sync/ and click I have a sync code
  8. On Linux: Paste the sync code from 6.

Actual result:

Partial sync on Windows (sync chain creator)
Bookmarks from Linux are not synced or are synced partially
image

Full sync on Linux.

Expected result:

Full sync on Windows (sync chain creator)
image

Full sync on Linux.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.59.33 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows 7 & Linux

The regression was introduced between 0.59.21 and 0.59.25.

Found by @LaurenWags .

cc @brave/legacy_qa @rebron @AlexeyBarabash @darkdh

@darkdh
Copy link
Member

darkdh commented Feb 1, 2019

@AlexeyBarabash it is caused by brave/brave-core#1188

@srirambv
Copy link
Contributor

srirambv commented Feb 1, 2019

Verification passed on

Brave 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Linux
  • Verification passed on different profiles on Linux, full bookmarks sync on both profiles
  • Verification passed on different profiles on Linux and Windows, full bookmarks sync on both profiles
    screenshot from 2019-02-01 13-46-14

Verification passed on

Brave 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows 10
  • Verified the STR mentioned in the description. Able to see full bookmarks sync on both win and linux
    image

Verified passed with

Brave 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X
  • Verified by having a macOS device with bookmarks and an Android device with bookmarks. After bookmarks were set up on both devices, a sync chain was created on macOS and joined by Android. Verified bookmarks from each devices synced to the other device.
  • Verified by having two macOS devices with bookmarks. After bookmarks were set up on both devices, a sync chain was created on macOS1 and joined by macOS2. Verified bookmarks from each devices synced to the other device.

Verification passed on

Brave 0.59.34 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows 7

@kjozwiak
Copy link
Member

kjozwiak commented Feb 5, 2019

Moving this into https://github.com/brave/brave-browser/milestone/15 as it was resolved by reverting brave/brave-core#1188 and pushed into the 0.59.34 release.

@kjozwiak kjozwiak modified the milestones: 1.x Backlog, 0.59.x - Release (Release Channel) Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment