Whitelisting access to chrome.sockets API for local dev with unpacked extension

[lidel]

Problem Summary

I am trying to whitelist access to chrome.sockets.* for local development with unpacked extension to test how feasible those APIs are for use in IPFS integration.

Why?

Related notes on bringing IPFS to Brave: #819 (comment)
Upstream issue to add support for chrome.sockets.* APIs to IPFS Companion: ipfs/ipfs-companion#664, cc #829

Steps to Reproduce

I suspect I am just missing some obvious step, so below is what I did:

1. I loaded an unpacked extension with sockets section added to manifest (this branch), it got assigned ID paanflafljinkomjoheoobkeigpakegp.

2. Generated ID shortcut via:

   $ echo -n paanflafljinkomjoheoobkeigpakegp | openssl sha1 | tr '[:lower:]' '[:upper:]'
   (STDIN)= CEBF34BE446B77F39E2C535566F8C27F9A460B1E

3. and added it to whitelists for sockets.* APIs in src/brave/common/extensions/api/_api_features.json)

--- a/common/extensions/api/_api_features.json
+++ b/common/extensions/api/_api_features.json
@@ -60,18 +60,18 @@
   }],
   "sockets.tcp": {
     "dependencies": ["manifest:sockets"],
-    "contexts": ["blessed_extension"],
-    "whitelist": ["3D9518A72EB02667A773B69DBA9E72E0F4A37423"]
+    "contexts": ["blessed_extension","unblessed_extension"],
+    "whitelist": ["3D9518A72EB02667A773B69DBA9E72E0F4A37423","CEBF34BE446B77F39E2C535566F8C27F9A460B1E"]
   },
   "sockets.tcpServer": {
     "dependencies": ["manifest:sockets"],
-    "contexts": ["blessed_extension"],
-    "whitelist": ["3D9518A72EB02667A773B69DBA9E72E0F4A37423"]
+    "contexts": ["blessed_extension","unblessed_extension"],
+    "whitelist": ["3D9518A72EB02667A773B69DBA9E72E0F4A37423","CEBF34BE446B77F39E2C535566F8C27F9A460B1E"]
   },
   "sockets.udp": {
     "dependencies": ["manifest:sockets"],
-    "contexts": ["blessed_extension"],
-    "whitelist": ["3D9518A72EB02667A773B69DBA9E72E0F4A37423"]
+    "contexts": ["blessed_extension","unblessed_extension"],
+    "whitelist": ["3D9518A72EB02667A773B69DBA9E72E0F4A37423","CEBF34BE446B77F39E2C535566F8C27F9A460B1E"]
   },
   "braveRewards": {
     "channel": "stable",

4. Rebuilt Brave via npm run build

5. Started it via npm start

6. Loaded extension again, it got the same ID (paanflafljinkomjoheoobkeigpakegp) but whitelisting did not work and I got this error:

   

I also tried to remove "whitelist" and added "unblessed_extension" to "context", but the result was the same.

Would appreciate some guidance on what am I missing, or where should I look.

[yrliou]

I think you’ll also need to add your extension into the whitelist in https://github.com/brave/brave-core/blob/master/common/extensions/api/_manifest_features.json

[lidel]

@yrliou that did the trick, thank you!